RFE-9585: Enable enableUserAlertmanagerConfig in cluster-monitoring-config baseline - #2818
Conversation
Make the supported alertmanagerMain.enableUserAlertmanagerConfig setting durable on ROSA/OSD so Hive SyncSet reconcile no longer strips customer platform AlertmanagerConfig routing for kube_* alerts. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@kiranrpatil12: This pull request references RFE-9585 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe monitoring configuration and generated ConfigMaps now set ChangesAlertmanager configuration enablement
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kiranrpatil12 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Commit make-generated SelectorSyncSet templates so pr-check no longer fails on uncommitted hack/*.tmpl churn from the CMO baseline change. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@kiranrpatil12: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @robotmaxtron and @tiwillia, Could you please review this PR and make any necessary changes? It's currently pending approval. |
What type of PR is this?
feature
What this PR does / why we need it?
Adds
alertmanagerMain.enableUserAlertmanagerConfig: trueto the Hive-managedcluster-monitoring-configbaseline so ROSA/OSD customers can durably route platformkube_*/Kube*alerts to customer email/webhook receivers viaAlertmanagerConfigCRs.Today the setting is valid and supported by CMO, but the fleet template omits it. Manual edits to
cluster-monitoring-configare removed on Hive SyncSet reconcile (~2h).Customer impact: After fleet rollout, customers can keep using platform Alertmanager for platform alert routing without the config being overwritten.
Important usage note (CMO):
enableUserAlertmanagerConfigonly applies when the dedicated UWM Alertmanager is disabled (alertmanager.enabled: false/ omitted inuser-workload-monitoring-config). If UWM Alertmanager is enabled, CMO does not merge userAlertmanagerConfiginto platform Alertmanager (verified on OCP 4.21).Which Jira/Github issue(s) this PR fixes?
Fixes https://redhat.atlassian.net/browse/RFE-9585
Special notes for your reviewer:
resources/cluster-monitoring-config/config.yamlpython3 scripts/generate-cmo-config.py(all UWM / non-UWM / FedRAMP variants)alertmanager-mainsecret or SREconfigure-alertmanager-operatorroutesAlertmanagerConfigCRAlertmanagerConfigfor email/webhook