OCPBUGS-66217: PerformanceProfile and Tuned CRDs during bootstrap

[MarSik]

Make sure both the main NTO CRDs are deployed early on bootstrap so day 0 rendering can rely on those two CRDs being available.

Summary by CodeRabbit

• Improvements
  • Updated performance and node-tuning resource definitions to support required initialization during system setup.

[openshift-ci-robot]

@MarSik: This pull request references Jira Issue OCPBUGS-66217, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Make sure both the main NTO CRDs are deployed early on bootstrap so day 0 rendering can rely on those two CRDs being available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 96f322ed-57df-4a9d-882e-8ef16b7e2e1e

📥 Commits

Reviewing files that changed from the base of the PR and between e4e47dc and 84be74d.

📒 Files selected for processing (2)

• manifests/20-performance-profile.crd.yaml
• manifests/20-tuned.crd.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The PerformanceProfile and Tuned custom resource definitions now include the release.openshift.io/bootstrap-required: "true" annotation.

Changes

CRD bootstrap annotations

Layer / File(s)	Summary
Add bootstrap annotations manifests/20-performance-profile.crd.yaml, manifests/20-tuned.crd.yaml	Both CRDs now declare the release.openshift.io/bootstrap-required: "true" annotation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 84be7

This is a small, localized CRD manifest change to make the required resources available earlier during bootstrap; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: tal-or

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the two CRDs and their deployment during bootstrap, which matches the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only two YAML CRD annotations; it adds no Ginkgo test titles or dynamic test-name content.
Test Structure And Quality	✅ Passed	The pull request changes only two CRD YAML annotations; the parent-to-HEAD diff contains no Ginkgo or test files, so these test-quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The pull request changes only two CRD manifest annotations and adds no Ginkgo e2e tests, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only two CRD YAML annotations and adds no Ginkgo e2e tests, so the SNO multi-node test check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The patch only adds bootstrap-required annotations to two CRDs; it adds no replicas, affinity, topology spread, node selectors, tolerations, or disruption budgets.
Ote Binary Stdout Contract	✅ Passed	The diff only adds bootstrap annotations to two CRD YAML files; it changes no main, suite setup, or process-level stdout behavior.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only two CRD annotations; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The patch adds only two bootstrap-required annotations. The introduced lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto implementation.
Container-Privileges	✅ Passed	The PR changes only two CRD annotations; neither changed manifest contains privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The pull request changes only two CRD YAML annotations; it adds no logging statements or sensitive data exposure.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Tal-or]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MarSik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-techpreview
/test e2e-gcp-pao
/test e2e-gcp-pao-updating-profile
/test e2e-gcp-pao-workloadhints
/test e2e-hypershift
/test e2e-hypershift-pao
/test e2e-no-cluster
/test e2e-upgrade

[MarSik]

/jira refresh

[openshift-ci-robot]

@MarSik: This pull request references Jira Issue OCPBUGS-66217, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (dhensel@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@MarSik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.