fix(collector): only declare hostPath volumes when needed (LOG-9713)

[vparfonov]

Description

Only declare hostPath volumes when their input sources are configured.

The collector pod spec unconditionally declares hostPath volumes for audit API, journal and OVN logs even when those inputs are not enabled.

This fix moves the volume declarations inside the same input-source conditions that control the volumeMounts, so app-only collectors don't declare unnecessary hostPath access.

/cc @Clee2691
/assign @jcantrill

Links

• Depending on PR(s):
• GitHub issue:
• JIRA: https://redhat.atlassian.net/browse/LOG-9713
• Enhancement proposal:

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e410ff3a-28bc-4119-b271-3e40c4c31671

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[qodo-for-rh-openshift]

PR Summary by Qodo

fix(collector): gate hostPath volumes on enabled inputs (LOG-9713)

🐞 Bug fix 🧪 Tests 🕐 20-40 Minutes

AI Description

• Stop declaring hostPath volumes for disabled collector input sources.
• Align volume declarations with existing volumeMount gating conditions.
• Extend daemonset pod spec test to exercise input-driven volume behavior.

Diagram

graph TD
A["ClusterLogForwarderSpec.inputs"] --> B["internalobs.Inputs()"] --> C1["Container inputs enabled"] --> F["HostPath volume(s)"] --> D["podSpec.volumes"] --> E["Collector DaemonSet Pod"]
A --> B --> C2["Journal enabled"] --> F --> D --> E
A --> B --> C3["Audit enabled"] --> F --> D --> E

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Derive volumes from volumeMount plan

• ➕ Prevents future drift between mount gating and volume gating
• ➕ Centralizes enablement logic in one place (mount planning)
• ➖ Requires refactoring PodSpec assembly order and/or exposing mount plan data
• ➖ More invasive change than needed for this bug fix

2. Central mapping table for input→(volumes,mounts)

• ➕ Reduces repeated conditional blocks and keeps sources consistent
• ➕ Easier to add new sources without duplicating patterns
• ➖ Slightly more indirection for a small set of sources
• ➖ May require more extensive test rewrites to validate mapping behavior

Recommendation: The PR’s approach (moving hostPath volume declarations under the same input-source conditions) is the right minimal fix for reducing unnecessary hostPath access. If this area continues to grow, consider a follow-up refactor to generate both volumes and mounts from a shared input→resource mapping to avoid divergence.

Files changed (2) +38 / -10

Bug fix (1) +33 / -10

collector.goConditionally add hostPath volumes only for enabled inputs +33/-10

Conditionally add hostPath volumes only for enabled inputs

• Replaces unconditional hostPath volume declarations in the daemonset PodSpec with per-input checks via internalobs.Inputs(). HostPath volumes for container logs, journal, and each audit source are appended only when the corresponding input is enabled, reducing unnecessary host filesystem access.

internal/collector/collector.go

Tests (1) +5 / -0

collector_test.goAdd explicit Inputs to daemonset pod spec test fixture +5/-0

Add explicit Inputs to daemonset pod spec test fixture

• Updates the daemonset PodSpec test setup to include application, infrastructure, and audit inputs. This exercises the new input-driven volume behavior and prevents regressions in volume gating.

internal/collector/collector_test.go

[qodo-for-rh-openshift]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

[jcantrill]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.