Update version to 6.2.13 - #3380
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoBump Cluster Logging operator version metadata to 6.2.13
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xperimental The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code Review by Qodo
Context used✅ Compliance rules (platform):
9 rules 1. Version label mismatch
|
| vendor="Red Hat, Inc." \ | ||
| version_minor="v6.2" \ | ||
| version="6.2.12" | ||
| version="6.2.13" |
There was a problem hiding this comment.
1. Version label mismatch 🐞 Bug ≡ Correctness
Dockerfile.art updates the image LABEL version to 6.2.13, but the built operator will still report version.Version as 6.2.0 because make build does not regenerate version/version.go. As a result, startup logs, common Kubernetes labels, and telemetry will continue to reflect 6.2.0 while the image metadata advertises 6.2.13.
Agent Prompt
### Issue description
`Dockerfile.art` bumps the container label to `6.2.13`, but the operator’s embedded version (`version.Version`) stays at `6.2.0` under this Dockerfile because it runs `make build` only.
### Issue Context
- `make build` does **not** run the `generate` target that writes `version/version.go` from `CI_CONTAINER_VERSION`/`VERSION`.
- The current checked-in `version/version.go` is `6.2.0`, and this value is used in logs and common labels.
### Fix
Pick one of the following (prefer an approach that guarantees the Docker label and embedded version are derived from the same single source of truth):
1) **Update `version/version.go` in this PR** to `6.2.13` so the binary reports the same version as the label.
2) **Teach `Dockerfile.art` to set the embedded version during build** (e.g., write `version/version.go` from a build ARG like `CI_CONTAINER_VERSION` before `make build`, or run the minimal step that updates just this file).
### Fix Focus Areas
- Dockerfile.art[1-12]
- Dockerfile.art[47-62]
- Makefile[89-95]
- Makefile[170-180]
- version/version.go[1-3]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/test images |
|
Unsupported PR languages |
|
@xperimental: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @jcantrill
/assign @xperimental
Links