OCPBUGS-105357: Fix TNF fencing skip for IPv6 bracketed stonith IPs.

[eggfoobar]

canFencingConfigBeSkipped compared the unbracketed secret IP to the bracketed value pcs stores after GetParsedIP(), so every tnf-setup retry re-ran stonith update --wait and timed out on IPv6 clusters.

Summary by CodeRabbit

• Bug Fixes

  • Improved IPv6 fencing configuration handling by recognizing equivalent bracketed and unbracketed address formats.
  • Prevented unnecessary fencing configuration updates when the stored IPv6 address already matches.

• Tests

  • Added regression coverage for matching and differing IPv6 fencing addresses.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Walkthrough

The fencing skip check now compares stored IP values with GetParsedIP(). Regression tests cover equivalent bracketed and unbracketed IPv6 addresses and detect different IPv6 addresses.

Changes

IPv6 fencing comparison

Layer / File(s)	Summary
Parsed IP skip check and regression coverage pkg/tnf/pkg/pcs/fencing.go, pkg/tnf/pkg/pcs/fencing_test.go	The comparison uses GetParsedIP() to preserve IPv6 brackets. Tests verify matching IPv6 values skip updates and different values trigger updates.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The added subtests use static titles: 'can be skipped with ipv6 bracketed cib ip' and 'needs update for different ipv6 address'; neither contains dynamic values.
Test Structure And Quality	✅ Passed	The changed tests use Go's table-driven testing package, not Ginkgo; they create no cluster resources, use no waits, and report got/want values in assertions.
Microshift Test Compatibility	✅ Passed	The added coverage is standard Go testing.Test with t.Run, not Ginkgo e2e tests, and it references no MicroShift-unsupported APIs or features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The added regression coverage is a standard Go testing.T unit test in pkg/tnf/pkg/pcs, not a new Ginkgo e2e test; it makes no SNO-relevant multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request changes only IPv6 fencing IP comparison logic and regression tests; it adds no manifests, controllers, replicas, affinity, topology constraints, selectors, taints, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The PR changes only fencing logic and tests. No changed line writes stdout; the OTE main has no stdout print, and vendored klog defaults to stderr.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The added cases are standard Go table tests, not Ginkgo e2e tests. They use IPv6 literals only and make no network or external-service calls.
No-Weak-Crypto	✅ Passed	The patch adds no weak cryptography and changes only IP normalization; the existing password equality comparison is unchanged from the parent commit.
Container-Privileges	✅ Passed	The PR changes only fencing.go and fencing_test.go. No container or Kubernetes manifest changes introduce privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds no logging; it changes IPv6 comparison and test fixtures only. Existing executor command, stdout, stderr, and errors pass through RedactPasswords before logging.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the IPv6 fencing skip fix implemented by the pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[eggfoobar]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-ipv6-degraded periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-ipv6-recovery periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-two-node-fencing-ipv6-certrotation

[openshift-ci]

@eggfoobar: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-ipv6-degraded
• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-ipv6-recovery
• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-two-node-fencing-ipv6-certrotation

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e1285ac0-919c-11f1-90f9-6b6997032252-0

[openshift-ci-robot]

@eggfoobar: This pull request references Jira Issue OCPBUGS-105357, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

canFencingConfigBeSkipped compared the unbracketed secret IP to the bracketed value pcs stores after GetParsedIP(), so every tnf-setup retry re-ran stonith update --wait and timed out on IPv6 clusters.

Summary by CodeRabbit

• Bug Fixes

• Improved IPv6 fencing configuration handling by recognizing equivalent bracketed and unbracketed address formats.

• Prevented unnecessary fencing configuration updates when the stored IPv6 address already matches.

• Tests

• Added regression coverage for matching and differing IPv6 fencing addresses.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eggfoobar]

/payload-job periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-ipv6-degraded periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-ipv6-recovery periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-two-node-fencing-ipv6-certrotation

[openshift-ci]

@eggfoobar: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-ipv6-degraded
• periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-ipv6-recovery
• periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-two-node-fencing-ipv6-certrotation

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b56ffb00-91e1-11f1-9f32-6b7fee66ccb0-0

[eggfoobar]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-upgrade

[openshift-ci]

@eggfoobar: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-upgrade
• periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0fcc6320-91e4-11f1-8f2d-d70fe34978cc-0

[eggfoobar]

/verified by ci

The CI lanes are passing install, the failures are infra related so this should be good to go

[openshift-ci-robot]

@eggfoobar: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

The CI lanes are passing install, the failures are infra related so this should be good to go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fonta-rh]

Nice clean fix!!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fonta-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/tnf/OWNERS [fonta-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fonta-rh]

/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic-ovn
/test e2e-agnostic-ovn-upgrade
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-single-node
/test e2e-gcp-operator
/test e2e-gcp-operator-disruptive
/test e2e-metal-ipi-ovn-ipv6
/test e2e-operator

[eggfoobar]

/retest-required

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 2f256f2 and 2 for PR HEAD ecb832b in total

[openshift-ci]

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@eggfoobar: Jira Issue OCPBUGS-105357: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

• openshift/cluster-etcd-operator#1670 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-105357 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

canFencingConfigBeSkipped compared the unbracketed secret IP to the bracketed value pcs stores after GetParsedIP(), so every tnf-setup retry re-ran stonith update --wait and timed out on IPv6 clusters.

Summary by CodeRabbit

• Bug Fixes

• Improved IPv6 fencing configuration handling by recognizing equivalent bracketed and unbracketed address formats.

• Prevented unnecessary fencing configuration updates when the stored IPv6 address already matches.

• Tests

• Added regression coverage for matching and differing IPv6 fencing addresses.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.