Skip to content

NO-JIRA: remove release-release template#5168

Open
neisw wants to merge 1 commit intoopenshift:mainfrom
neisw:job-name-generator-deprecate-periodics
Open

NO-JIRA: remove release-release template#5168
neisw wants to merge 1 commit intoopenshift:mainfrom
neisw:job-name-generator-deprecate-periodics

Conversation

@neisw
Copy link
Copy Markdown
Contributor

@neisw neisw commented May 7, 2026

openshift-release-release-%s-periodics.yaml look to only contain older multi release upgrade jobs that aren't monitored for signal.

Those definitions have not been updated for 5.0. Removing them from the periodicURLTemplates we monitor for job name updating

Job Run Aggregator: Removes monitoring of deprecated release-release periodic jobs

The job run aggregator's job name generator component no longer fetches or monitors the openshift-release-release-*-periodics.yaml template from the OpenShift release repository.

What Changed

The periodicURLTemplates list in pkg/jobrunaggregator/jobtableprimer/job_name_generator.go was updated to remove one template:

  • Removed: https://raw.githubusercontent.com/openshift/release/main/ci-operator/jobs/openshift/release/openshift-release-release-%s-periodics.yaml
  • Kept: https://raw.githubusercontent.com/openshift/release/main/ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-%s-periodics.yaml

The templateException list (which provided 404-handling exceptions for specific templates) was also cleared, as it only contained an exception for the removed openshift-release-release-5.0-periodics.yaml file.

Why

The openshift-release-release-* template contains older multi-release upgrade jobs that are not actively monitored for disruption signal. Those job definitions have not been updated for version 5.0 and are no longer relevant to current CI monitoring requirements.

Impact on CI Users and Operators

  • The job run aggregator will no longer attempt to load or analyze periodic jobs from the deprecated release-release template
  • Job name generation and aggregation logic will only process Hypershift and release controller job definitions
  • This reduces unnecessary network requests and simplifies the set of jobs monitored for disruption analysis

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@neisw: This pull request explicitly references no jira issue.

Details

In response to this:

openshift-release-release-%s-periodics.yaml look to only contain older multi release upgrade jobs that aren't monitored for signal.

Those definitions have not been updated for 5.0. Removing them from the periodicURLTemplates we monitor for job name updating

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 280158c7-f5e8-409e-a8f7-823d4ad95526

📥 Commits

Reviewing files that changed from the base of the PR and between 582d460 and b2000cb.

📒 Files selected for processing (1)
  • pkg/jobrunaggregator/jobtableprimer/job_name_generator.go

📝 Walkthrough

Walkthrough

A single file modification that refines HTTP 404 exception handling for template configs. When a config URL returns 404 and matches an exception substring in templateException, the code logs a template-specific message and skips processing that config, replacing a generic pre-branch-cut exception behavior.

Changes

Template Exception Handling Refinement

Layer / File(s) Summary
Data Shape
pkg/jobrunaggregator/jobtableprimer/job_name_generator.go
New templateException slice introduces URL-specific 404 exception handling; constrained to openshift-release-release-5.0-periodics.yaml.
404 Exception Logic
pkg/jobrunaggregator/jobtableprimer/job_name_generator.go
readConfigURL now emits "skipping template exception config" log and returns skip=true when matching a template exception, replacing the prior pre-branch-cut-specific exception message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Coverage For New Features ⚠️ Warning PR adds new exported methods with HTTP/unmarshaling logic but includes no unit tests. Per check: new Go functions/methods require corresponding unit tests. Add unit tests for UpdateURLsForAllReleases(), GenerateJobNames(), and critical readConfigURL() 404 handling path
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'NO-JIRA: remove release-release template' accurately reflects the main change: removing the openshift-release-release template from periodic job monitoring.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed Error handling is correct: no ignored errors, proper fmt.Errorf %w wrapping, no panic() calls, proper nil checks, and safe pointer dereferencing.
Stable And Deterministic Test Names ✅ Passed This PR does not contain or modify any Ginkgo tests. The change is limited to production code in job_name_generator.go. The custom check for Ginkgo test name stability is not applicable.
Test Structure And Quality ✅ Passed No Ginkgo tests present in PR. The check is not applicable. Changes are only to production code in job_name_generator.go, with no test files added or modified in the jobtableprimer directory.
Microshift Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests (It(), Describe(), Context(), When()). Changes are in job configuration generation logic only, not test code. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR does not add Ginkgo e2e tests. Changes are to CI tooling job configuration code only, not e2e test code. Custom check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR modifies a CI utility that aggregates job names from URLs. It contains no Kubernetes scheduling constraints, affinity rules, topology spread constraints, or workload scheduling logic.
Ote Binary Stdout Contract ✅ Passed Job-run-aggregator is not an OTE binary. The check applies to OTE binaries communicating with openshift-tests. This PR is inapplicable to the check.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. It modifies job configuration monitoring code in job_name_generator.go. The custom check applies only to "new Ginkgo e2e tests" which are absent here.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Prucek and psalajova May 7, 2026 18:43
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2026
@neisw
Copy link
Copy Markdown
Contributor Author

neisw commented May 8, 2026

/retest-required

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

@neisw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes b2000cb link false /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@neisw
Copy link
Copy Markdown
Contributor Author

neisw commented May 8, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2026
@smg247
Copy link
Copy Markdown
Member

smg247 commented May 8, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants