NE-2859: Add Containerfile and FBC for OCP v4.23 and v5.0 - #320
NE-2859: Add Containerfile and FBC for OCP v4.23 and v5.0#320grzpiotrowski wants to merge 2 commits into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@grzpiotrowski: This pull request references NE-2859 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Add `Containerfile.aws-load-balancer-operator-catalog-v4-23`. - Add `catalog/v4.23/catalog-template.yaml`. - Run `OCP_VERSION=4.23 make generate-catalog` to generate the catalog. Note: The catalog for OCP v4.23 is added without the already deprecated ALBO v1.1.0, v1.1.1 and the stable-v1.1 channel.
- Adapt the generate-catalog Makefile target to set the correct flag for generating the catalog for OCP v5.x. - Add `Containerfile.aws-load-balancer-operator-catalog-v5-0`. - Add `catalog/v5.0/catalog-template.yaml`. - Run `OCP_VERSION=5.0 make generate-catalog` to generate the catalog. Note: The catalog for OCP v5.0 is added without the already deprecated ALBO v1.1.0, v1.1.1 and the stable-v1.1 channel.
e4c0f8f to
9bf490e
Compare
|
@grzpiotrowski: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @alebedev87 |
|
/assign @bentito |
5 participants
This PR adds Containerfiles and FBC catalogs for OCP v4.23 and v5.0.
Steps:
Containerfile.aws-load-balancer-operator-catalog-v4-23.catalog/v4.23/catalog-template.yaml.OCP_VERSION=4.23 make generate-catalogto generate the catalog.generate-catalogMakefile target variables to set the--migrate-level=bundle-object-to-csv-metadataflag generating the catalog for OCP v5.x.Containerfile.aws-load-balancer-operator-catalog-v5-0.catalog/v5.0/catalog-template.yaml.OCP_VERSION=5.0 make generate-catalogto generate the catalog.Note:
Both new catalogs for OCP v4.23 and v5.0 are added without the already deprecated ALBO
v1.1.0,v1.1.1and without the deprecatedstable-v1.1channel.This PR should be merged before: konflux-release-data!21768: NE 2859: ALBO: Add FBC v4.23 and v5.0 Application, Component, RPA, ReleasePlan, but should be reviewed together with it, as the
Componentscreated by the mentioned MR reference the Containerfiles from this PR. After the konflux-release-data!21768 merges, automation will create PRs with .tekton pipelines inaws-load-balancer-operatorrepository, which will excercise the whole setup in that automated PR by running FBC build pipelines.