[master] ACM-40436: Bump Go toolchain to go1.26.5 to fix stdlib CVEs - #10770
Conversation
|
@shay23bra: This pull request references ACM-40436 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe pull request updates the Go toolchain directive from 1.26.2 to 1.26.5 in the root, API, client, and models modules. ChangesGo toolchain alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shay23bra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 5: Pin Go toolchain usage to exactly 1.26.5 across all builds: update the
toolchain declarations in go.mod (anchor, lines 5-5), api/go.mod (sibling, lines
5-5), client/go.mod (sibling, lines 5-5), and models/go.mod (sibling, lines
5-5), and replace floating 1.26 UBI Go build-image tags in root, API, client,
models, CI, and release build configurations with Go 1.26.5 tags or enforce the
same version through build-time go version checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 525535b9-41ab-4b5d-871d-7ee7e01b140a
📒 Files selected for processing (4)
api/go.modclient/go.modgo.modmodels/go.mod
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
- Coverage 44.69% 44.69% -0.01%
==========================================
Files 426 426
Lines 73903 73903
==========================================
- Hits 33033 33031 -2
- Misses 37915 37916 +1
- Partials 2955 2956 +1 🚀 New features to boost your workflow:
|
|
/lgtm |
|
/retest |
|
/override ci/prow/edge-e2e-ai-operator-disconnected-capi ci/prow/edge-e2e-ai-operator-ztp-capi |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/edge-e2e-ai-operator-disconnected-capi, ci/prow/edge-e2e-ai-operator-ztp-capi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/edge-e2e-ai-operator-ztp |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/edge-e2e-ai-operator-ztp DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-subsystem-kubeapi-aws |
|
@shay23bra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bump Go toolchain from go1.26.2 to go1.26.5 in all go.mod files.
Fixed CVEs
Summary by CodeRabbit