OPRUN-4466: Add NewOLMConfigAPI feature gate

[tmshort]

No description provided.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@tmshort: This pull request references OPRUN-4466 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @tmshort! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 045d02d9-a970-43fe-9ddd-5a0bf2bbe888

📥 Commits

Reviewing files that changed from the base of the PR and between 9cdb934 and 969e597.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

🚧 Files skipped from review as they are similar to previous changes (4)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• features.md
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

---

📝 Walkthrough

Walkthrough

This pull request adds a new feature gate named NewOLMConfigAPI. A Go variable for the feature gate is introduced in the features package with metadata and registration. The feature gate is added to multiple 4.10 environment-specific YAML manifests; it is enabled in SelfManagedHA DevPreviewNoUpgrade and TechPreviewNoUpgrade, and disabled in the other provided configurations.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author; however, the changeset is straightforward and the title adequately conveys the purpose.	Consider adding a pull request description that explains the purpose and scope of the NewOLMConfigAPI feature gate.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a new feature gate named NewOLMConfigAPI, which is reflected consistently across all modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	This pull request does not introduce or modify any Ginkgo tests. The PR adds a new feature gate called NewOLMConfigAPI by modifying features.md, features/features.go, and various YAML configuration files. None of these changes include Ginkgo test files or test definitions.
Test Structure And Quality	✅ Passed	This PR contains no Ginkgo test code, only feature gate definitions and YAML manifests, making the test structure quality check inapplicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

[qodo-code-review]

Review Summary by Qodo

Add NewOLMConfigAPI feature gate for OLM configuration API

✨ Enhancement

Walkthroughs

Description

• Add NewOLMConfigAPI feature gate definition
• Enable feature in SelfManaged cluster profiles
• Update feature gate manifests across all deployment configurations
• Document feature in features.md reference table

Diagram

flowchart LR
  A["NewOLMConfigAPI Feature Gate"] --> B["features.go Definition"]
  A --> C["Feature Gate Manifests"]
  A --> D["Documentation"]
  B --> E["SelfManaged Profiles"]
  C --> F["Hypershift Configs"]
  C --> G["SelfManagedHA Configs"]
  D --> H["features.md Table"]

Loading

File Changes

1. features/features.go ✨ Enhancement +8/-0

Define NewOLMConfigAPI feature gate

features/features.go

---

2. features.md 📝 Documentation +1/-0

Add NewOLMConfigAPI to feature table

features.md

---

3. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in default profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

View more (7)

4. payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in dev preview profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml

---

5. payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in OKD profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

---

6. payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in tech preview profile

payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml

---

7. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in HA default profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

---

8. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in HA dev preview profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml

---

9. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in HA OKD profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

---

10. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in HA tech preview profile

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

[tmshort]

Dependent on: openshift/enhancements#1915

[everettraven]

Still the right contact person?

[tmshort]

Updated, thanks!

[everettraven]

/lgtm

Should not merge until openshift/enhancements#1915 has

/hold

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kuiwang02]

/verified by @kuiwang02

[openshift-ci-robot]

@kuiwang02: This PR has been marked as verified by @kuiwang02.

Details

In response to this:

/verified by @kuiwang02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tmshort]

/test e2e-aws-ovn

[tmshort]

/unhold

openshift/enhancements#1915 has merged

[openshift-ci]

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.