Fix Jackson 2.21+ compatibility for JREThrowableFinalMethods#1010
Merged
Fix Jackson 2.21+ compatibility for JREThrowableFinalMethods#1010
Conversation
Remove @requiredargsconstructor which generates @ConstructorProperties on the all-args constructor, conflicting with the no-arg @JsonCreator. Change @JsonCreator to accept nullable parameters with defaults, matching the pattern from #1007. This resolves the InvalidDefinitionException: Conflicting property-based creators reported in issue #1003.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidDefinitionException: Conflicting property-based creatorserror reported in issue Jackson 2.21+ compatibility: InvalidDefinitionException due to conflicting creators in ReplaceAWTGetPeerMethod and ReplaceComSunAWTUtilitiesMethods #1003. The "Lombok Best Practices" commit introduced@RequiredArgsConstructor(access = AccessLevel.PACKAGE), which generates a constructor with@ConstructorProperties, conflicting with the existing no-arg@JsonCreator.Changes
@RequiredArgsConstructorfromJREThrowableFinalMethods@JsonCreatorto accept nullable parameters with defaults, matching the pattern used in Fix Jackson 2.21+ conflicting creators in AWT recipes #1007This approach is consistent with how
ReplaceAWTGetPeerMethodwas fixed for Jackson 2.21+ compatibility.