Removed now obsolete fixed issuer SPI and cleanup env vars and README.md - #31
Merged
Conversation
MartinaeyNL
reviewed
Aug 3, 2026
MartinaeyNL
left a comment
MartinaeyNL
left a comment
Member
There was a problem hiding this comment.
The changes look OK to me. (haven't tested the branch locally)
Member
Author
|
I have been testing this image locally and all working as expected |
There was a problem hiding this comment.
Pull request overview
This PR removes the now-obsolete “fixed issuer” SPI module (previously used to force a fixed token issuer) now that Keycloak hostname V2 can cover the same scenario, and cleans up related Docker/README configuration.
Changes:
- Removed the
fixed-issuerGradle subproject and its SPI implementation classes. - Updated the Docker image build/runtime configuration to drop the issuer provider wiring and related env var handling.
- Updated README instructions related to issuer fixing and refreshed theme development run instructions.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle | Removes fixed-issuer from the included Gradle modules. |
| README.md | Removes fixed-issuer documentation and updates theme dev run instructions. |
| Dockerfile | Stops copying/configuring the issuer provider and removes issuer-related CLI args/env handling. |
| build.gradle | Adds the base plugin to the root project. |
| fixed-issuer/src/main/java/org/openremote/keycloak/IssuerInitializerProvider.java | Deleted (removes issuer override implementation). |
| fixed-issuer/src/main/java/org/openremote/keycloak/InitializerSpi.java | Deleted (removes custom SPI registration). |
| fixed-issuer/src/main/java/org/openremote/keycloak/InitializerProviderFactory.java | Deleted (removes initializer provider factory interface). |
| fixed-issuer/build.gradle | Deleted (removes issuer provider build configuration). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
@MartinaeyNL @denniskuijs I've applied the useful comment from copilot and I believe this is ready now |
MartinaeyNL
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixed issuer SPI was a hack which is no longer needed as keycloak hostname V2 allows for this scenario so it can be removed.