Use ESP_PWR_LVL_P9 enum for BLE TX power#99
Merged
zjwhitehead merged 2 commits intoesp-idffrom Mar 25, 2026
Merged
Conversation
Merged
Co-authored-by: zjwhitehead <4623792+zjwhitehead@users.noreply.github.com> Agent-Logs-Url: https://github.com/openppg/eppg-controller/sessions/3e86426f-2b01-4f3a-a03a-954f9d772ddf
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from review on ESP-IDF + BLE OTA pull request
Use ESP_PWR_LVL_P9 enum for BLE TX power
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NimBLEDevice::setPower(9)used a raw integer which is ambiguous — in ESP-IDF theesp_power_level_tenum indices don't map 1:1 to dBm values, so9does not mean +9 dBm at the ESP-IDF layer.Change
src/sp140/ble/ble_core.cpp: ReplacesetPower(9)withsetPowerLevel(ESP_PWR_LVL_P9), using the enum-based API available in NimBLE-Arduino v2.x on ESP32 platforms.ESP_PWR_LVL_P9is the correctesp_power_level_tconstant for +9 dBm and makes the intent unambiguous.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.