Conversation
woolfg
left a comment
woolfg
left a comment
There was a problem hiding this comment.
cool, just smaller remarks...especially about the schema
| total_impressions INTEGER NOT NULL, | ||
| total_considerations INTEGER NOT NULL, | ||
| total_streams INTEGER NOT NULL, | ||
| considerations_conversion_rate DECIMAL(10,5), |
There was a problem hiding this comment.
as this is percent and is always smaller than 0 I would suggest to store the value as a promille, so just unsigned 4 digits are fine?
There was a problem hiding this comment.
Looking at the context and the fact that this is an API data format that we don't control, I think the current approach is reasonable. The conversion to promille would require more changes in the application logic and might not provide significant benefits over the current decimal representation.
I'd like to keep the current implementation since the data format comes from the external API and the current storage is adequate.
There was a problem hiding this comment.
2 vs. 6 bytes, but ok, DECIMAL(9,5) would be at least just 5 bytes, or (5,3) would be also sufficient for a percent
mre
changed the title
mre
force-pushed
the
anchor-impressions
branch
from
a35a51f to
a2b8f13
Compare
- Add null check for rawPayload.range in impressions endpoint - Fix type conversion by using correct payload.data.data structure - Exclude test files from TypeScript build to prevent Jest type errors
woolfg
left a comment
woolfg
left a comment
There was a problem hiding this comment.
is this the same for spotify, then we could rename the tables to spotify and use it for anchor and spotify?
|
@woolfg is this still needed or shall we close it? I think we don't need it anymore as Anchor is already on its way out. |
|
considering openpodcast/pipelines#90 (comment) we might reuse the spotify api but we need a new mapping table or the additional information about the spoitify id. I have seen it already somewhere, maybe metadata of episodes. this would be sufficient. |
2 participants
Introduce support for anchor impressions, including the necessary database schema changes and API integration to handle impression data.
See https://github.com/openpodcast/anchor-connector/pull/5