Skip to content

Use better JBS link for searches#171

Closed
coffeys wants to merge 2 commits intoopenjdk:masterfrom
coffeys:patch-1
Closed

Use better JBS link for searches#171
coffeys wants to merge 2 commits intoopenjdk:masterfrom
coffeys:patch-1

Conversation

@coffeys
Copy link
Copy Markdown
Contributor

@coffeys coffeys commented Feb 27, 2026

Jira no longer allows searches via the main landing page (text box in top right hand corner) if you're logged out of the system


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/171/head:pull/171
$ git checkout pull/171

Update a local copy of the PR:
$ git checkout pull/171
$ git pull https://git.openjdk.org/guide.git pull/171/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 171

View PR using the GUI difftool:
$ git pr show -t 171

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/guide/pull/171.diff

Using Webrev

Link to Webrev Comment

Jira no longer allows searches via the main landing page (text box in top right hand corner) if you're logged out of the system
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Feb 27, 2026

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Feb 27, 2026

@coffeys This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Use better JBS link for searches

Reviewed-by: iris, kcr, jwilhelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @JesperIRL) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Feb 27, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Feb 27, 2026

Webrevs


* Before filing, verify that there isn't an open issue already filed.
* Search [JBS](https://bugs.openjdk.org/) for things like the name of the failing test, assert messages, the name of the source code file where a crash occurred etc.
* Search [JBS](https://bugs.openjdk.org/issues/?jql=) for things like the name of the failing test, assert messages, the name of the source code file where a crash occurred etc.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the https://bugs.openjdk.org/browse/JDK-8212207 type links still work well in JIRA UI.

Not sure if we need to change those. In your example above, I see the UI rendering a comment to say "7 of 367464" which suggests an extra load is put on the query system while wanting to view just one bug etc.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok so we are all referring to just this "search" link then. Yes - confining it to the JDK project seems reasonable then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, I had a typo. I meant what Roger said.

@openjdk openjdk bot added the ready label Feb 27, 2026
@coffeys
Copy link
Copy Markdown
Contributor Author

coffeys commented Mar 2, 2026

/integrate

@openjdk openjdk bot added the sponsor label Mar 2, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 2, 2026

@coffeys
Your change (at version cc82cc7) is now ready to be sponsored by a Committer.

@JesperIRL
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 3, 2026

Going to push as commit bd21555.

@openjdk openjdk bot added the integrated label Mar 3, 2026
@openjdk openjdk bot closed this Mar 3, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 3, 2026

@JesperIRL @coffeys Pushed as commit bd21555.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants