Decouple the ASP.NET Core/OWIN integration options from the authentication scheme options#2478
Merged
Merged
Conversation
…ation scheme options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenIddict doesn't use named options for its own options, except for the 3 authentication handlers (due to the fact the authentication options in ASP.NET Core are always named). Unfortunately, the current implementation of the ASP.NET Core integrations is suboptimal as you end with 2 instances of
OpenIddictClientAspNetCoreOptions/OpenIddictServerAspNetCoreOptions/OpenIddictValidationAspNetCoreOptions: one with a non-empty name - used by ASP.NET Core's authentication stack - and one with an empty one, used by OpenIddict itself.To fix that, this PR removes the
AuthenticationSchemeOptionsinheritance so thatOpenIddictClientAspNetCoreOptions/OpenIddictServerAspNetCoreOptions/OpenIddictValidationAspNetCoreOptionsare no longer used by ASP.NET Core. A similar approach (but slightly different) was used for OWIN/Katana.