Skip to content

Adds Map of Vietnam #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crunchybbb2 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adds Map of Vietnam #4592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd4d20a
vietnam map
crunchybbb2 Jul 7, 2026
6489bc1
Merge branch 'openfrontio:main' into vietnam
crunchybbb2 Jul 13, 2026
a65a983
adds teamspawns and fix image.png of vietnam
crunchybbb2 Jul 13, 2026
c4e7d8d
Merge branch 'vietnam' of https://github.com/crunchybbb2/OpenFrontIO …
crunchybbb2 Jul 13, 2026
a05f235
prettier
crunchybbb2 Jul 13, 2026
7ed6f51
minor fixes
crunchybbb2 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added map-generator/assets/maps/vietnam/image.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
203 changes: 203 additions & 0 deletions map-generator/assets/maps/vietnam/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,203 @@
{
"additionalNations": [
{
"coordinates": [1085, 1363],
"flag": "vn",
"name": "Ha Tinh"
},
{
"coordinates": [1093, 766],
"flag": "vn",
"name": "Ninh Binh"
},
{
"coordinates": [1158, 696],
"flag": "vn",
"name": "Hung Yen"
},
{
"coordinates": [1237, 514],
"flag": "vn",
"name": "Bac Ninh"
},
{
"coordinates": [1184, 362],
"flag": "vn",
"name": "Lang Son"
},
{
"coordinates": [984, 384],
"flag": "vn",
"name": "Thai Nguyen"
},
{
"coordinates": [832, 658],
"flag": "vn",
"name": "Phu Tho"
},
{
"coordinates": [383, 419],
"flag": "vn",
"name": "Dien Bien"
},
{
"coordinates": [559, 261],
"flag": "vn",
"name": "Lai Chau"
},
{
"coordinates": [1086, 216],
"flag": "vn",
"name": "Cao Bang"
},
{
"coordinates": [748, 406],
"flag": "vn",
"name": "Lao Cai"
},
{
"coordinates": [1656, 2179],
"flag": "South Vietnam",
"name": "Quang Ngai"
},
{
"coordinates": [1693, 2401],
"flag": "South Vietnam",
"name": "Gia Lai"
},
{
"coordinates": [1744, 2797],
"flag": "South Vietnam",
"name": "Khanh Hoa"
},
{
"coordinates": [1373, 2862],
"flag": "South Vietnam",
"name": "Dong Nai"
},
{
"coordinates": [1034, 3089],
"flag": "South Vietnam",
"name": "Dong Thap"
},
{
"coordinates": [1146, 3248],
"flag": "South Vietnam",
"name": "Vinh Long"
},
{
"coordinates": [885, 3379],
"flag": "South Vietnam",
"name": "Ca Mau"
},
{
"coordinates": [898, 3175],
"flag": "South Vietnam",
"name": "An GIang"

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Fix "An GIang" capitalization typo.

The province name should be "An Giang" (lowercase 'g'). "GIang" is not a correct spelling of any Vietnamese province.

💚 Proposed fix 
-      "name": "An GIang"
+      "name": "An Giang"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"name": "An GIang"
"name": "An Giang"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@map-generator/assets/maps/vietnam/info.json` at line 96, Update the province
name value in the Vietnam map metadata from “An GIang” to “An Giang,” preserving
all other fields unchanged.

},
{
"coordinates": [1180, 2921],
"flag": "South Vietnam",
"name": "Tay Ninh"
}
],
"id": "vietnam",
"name": "vietnam",
Comment on lines +104 to +105

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Capitalize the map name to "Vietnam".

All other maps use properly capitalized name values (e.g., "Africa", "Amazon River", "Korea"). The lowercase "vietnam" is inconsistent and cascades into the GameMapType enum key in Maps.gen.ts, which should be UpperCamelCase (Vietnam), and the localization display value in en.json.

💚 Proposed fix 
-  "name": "vietnam",
+  "name": "Vietnam",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"id": "vietnam",
"name": "vietnam",
"id": "vietnam",
"name": "Vietnam",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@map-generator/assets/maps/vietnam/info.json` around lines 104 - 105, Update
the map name value in the Vietnam map metadata from lowercase to “Vietnam”,
preserving the existing id. Regenerate the dependent GameMapType entry in
Maps.gen.ts and the English localization display value so both use the
capitalized name consistently.

"translation_key": "map.vietnam",
"categories": ["new", "countries", "asia"],
"multiplayer_frequency": 4,
"special_team_count": 2,
"nations": [
{
"coordinates": [1227, 3020],
"flag": "South Vietnam",
"name": "Saigon"
},
{
"coordinates": [1038, 3287],
"flag": "South Vietnam",
"name": "Can Tho"
},
{
"coordinates": [1670, 2588],
"flag": "South Vietnam",
"name": "Dak Lak"
},
{
"coordinates": [1633, 1983],
"flag": "South Vietnam",
"name": "Da Nang"
},
{
"coordinates": [1549, 2868],
"flag": "South Vietnam",
"name": "Lam Dong"
},
{
"coordinates": [1547, 1822],
"flag": "South Vietnam",
"name": "Hue"
},
{
"coordinates": [617, 3129],
"flag": "South Vietnam",
"name": "Phu Quoc"
},
{
"coordinates": [899, 1045],
"flag": "vn",
"name": "Nghe An"
},
{
"coordinates": [1248, 1584],
"flag": "South Vietnam",
"name": "Quang Tri"
},
{
"coordinates": [1000, 830],
"flag": "vn",
"name": "Thanh Hoa"
},
{
"coordinates": [1016, 584],
"flag": "vn",
"name": "Ha Noi"
},
{
"coordinates": [1224, 628],
"flag": "vn",
"name": "Hai Phong"
},
{
"coordinates": [1426, 487],
"flag": "vn",
"name": "Quang Ninh"
},
{
"coordinates": [853, 237],
"flag": "vn",
"name": "Tuyen Quang"
},
{
"coordinates": [609, 538],
"flag": "vn",
"name": "Son La"
}
],
"teamGameSpawnAreas": {
"2": [
{
"height": 1360,
"width": 1976,
"x": 0,
"y": 0
},
{
"height": 2200,
"width": 1976,
"x": 0,
"y": 1360
}
]
}
}
1 change: 1 addition & 0 deletions resources/lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,7 @@
"twolakes": "Two Lakes",
"unitedstates": "United States",
"venice": "Venice",
"vietnam": "vietnam",

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Capitalize the map display name to "Vietnam".

All other map entries use properly capitalized display names (e.g., "Africa", "Korea", "Venice"). The value "vietnam" will appear lowercase in the map picker UI. The key "vietnam" is correct (it matches the map id), but the value should be "Vietnam".

💚 Proposed fix 
-    "vietnam": "vietnam",
+    "vietnam": "Vietnam",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"vietnam": "vietnam",
"vietnam": "Vietnam",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@resources/lang/en.json` at line 1020, Update the "vietnam" map localization
entry in the language resource so its display value is capitalized as "Vietnam",
while preserving the lowercase key matching the map ID.

"warshipwarship": "Warship Warship",
"world": "World",
"worldinverted": "World Inverted",
Expand Down
Loading
Loading