Use starts_with instead of startswith in split-file.cpp#119
Merged
adamdruppe merged 2 commits intoJul 13, 2026
Conversation
Contributor
Author
|
Requesting review This change is enough to allow successful building of LDC with LLVM 19, while still supporting LLVM 17. I haven't actually tried building with LLVM 17 locally though (I'm doing this to avoid having to install yet another version of LLVM). We'll see if CI passes. |
Contributor
|
omg if it actually works i might be willing to update the llvm, i just didn't even want to fight with it. |
Contributor
Author
|
Yeah. I still need to make sure the resulting They sometimes do things like #189416 which causes runtime breakage without compile-time breakage. So even if LDC builds, it may not be usable. We'll see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringRef::startswithwas deprecated in LLVM 18, and removed in LLVM 19.It's replacement is
StringRef::starts_with(a simple rename/alias), introduced in LLVM 16.