[RT-7.3/RT-7.4] Update as-path-set deviation for Arista

[yini101]

Arista now supports match-as-path-set so we can remove match_as_path_set_unsupported from the deviation. However, EOS requires ip as-path regex-mode string to match as-path-set members as POSIX regexes. Adding routing_policy_as_path_set_enable_regex_mode deviation which would configure that in the test.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the BGP AS path set matching logic for Arista devices within the testing framework. It updates the system to reflect Arista's enhanced capabilities by removing an obsolete deviation and introduces a new mechanism to correctly configure AS path set matching using POSIX regex mode, ensuring proper interaction with Arista EOS requirements.

Highlights

• Arista AS Path Set Support Update: The match_as_path_set_unsupported deviation for Arista devices has been removed, indicating that Arista now supports match-as-path-set functionality.
• New Deviation for Arista EOS Regex Mode: A new deviation, routing_policy_as_path_set_enable_regex_mode, has been introduced to specifically enable POSIX regex mode for AS path set members on Arista EOS, which requires the ip as-path regex-mode string command.
• Configuration Plugin Implementation: A new configuration plugin function, DeviationAristaRoutingPolicyBGPAsPathMatchMode, was added to apply the necessary CLI command for enabling AS path regex mode on Arista devices when the new deviation is active.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5262 / b04f6d2

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Cisco 8000E		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Cisco XRd		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Juniper ncPTX		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Nokia SR Linux		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Openconfig Lemming		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Cisco 8808		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Juniper PTX10008		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set
Nokia 7250 IXR-10e		RT-7.4: BGP Policy AS Path Set and Community Set RT-7.3: BGP Policy AS Path Set

Help

[gemini-code-assist]

Code Review

This pull request introduces a new deviation, RoutingPolicyAsPathSetEnableRegexMode, to address the requirement for explicit POSIX regex matching configuration for BGP AS Path Sets on Arista devices. The changes include updating protobuf definitions, generating corresponding Go code, adding an accessor function in internal/deviations, and implementing a new configuration plugin in internal/cfgplugins to apply the necessary CLI command. The relevant BGP policy tests have been updated to utilize this new deviation. Feedback suggests improving test robustness by adding default cases to switch statements and using t.Errorf for non-fatal errors, correcting a typo in a function comment, and fixing an issue tracker URL format to comply with the repository's style guide.