Repository navigation
Add queue DLR deleted packets and bytes stats - #2280
msherif1234 wants to merge 1 commit into
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
since you changed enums names you need to squash and force push to this branch |
cbee6e6 to
317d6b0
Compare
|
@msherif1234 - are you able to have a quick discussion of this PR in the SAI community meeting on 5/7? |
Hi @tjchadaga sure I will join today meeting Thank you!! |
msherif1234
changed the title
|
@JaiOCP can you please checkout the latest update and let me know if you have any more comments or feedback ? |
317d6b0 to
958fbed
Compare
msherif1234
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| SAI_QUEUE_STAT_TX_TRIM_PACKETS = 0x0000002e, | ||
|
|
||
| /** Get packets deleted from a queue when PFC Deadlock Recovery is triggered with SAI_PACKET_ACTION_DROP [uint64_t] */ | ||
| SAI_QUEUE_STAT_PFC_DLR_DELETED_PACKETS = 0x0000002f, |
There was a problem hiding this comment.
@msherif1234 shall we name them dropped instead of deleted ? Also, will this count packets dropped
- if SW based recovery happens and acl drops the packets on port, egress queue
- if HW based recovery happens and HW drops packets on port, egress queue
There was a problem hiding this comment.
we tried to use deleted instead of dropped to align with an existing similar field as stated in the PR description.
for either sw/hw recovery this will count the dropped packets and its orthogonal to acl drops
|
When the PFC deadlock mitigation action is set to drop, the following packets are discarded: (1) packets already enqueued and still in the queue when the mitigation triggers, and (2) packets that arrive afterward and attempt to enqueue while the mitigation is active. Are the newly introduced stats intended to count both sets of dropped packets, or only the packets that were already enqueued in the queue before the mitigation action was triggered? It would help to clarify the comments in the header file. |
| /** Get packets deleted from a queue when PFC Deadlock Recovery is triggered with SAI_PACKET_ACTION_DROP [uint64_t] */ | ||
| SAI_QUEUE_STAT_PFC_DLR_DELETED_PACKETS = 0x0000002f, | ||
|
|
||
| /** Get bytes deleted from a queue when PFC Deadlock Recovery is triggered with SAI_PACKET_ACTION_DROP [uint64_t] */ |
There was a problem hiding this comment.
Please consider rewording as per existing conventions: /** Get bytes deleted => /** Bytes deleted
| /** Packets trimmed and successfully transmitted on a trim queue. Counted on the original trimming-eligible queue [uint64_t] */ | ||
| SAI_QUEUE_STAT_TX_TRIM_PACKETS = 0x0000002e, | ||
|
|
||
| /** Get packets deleted from a queue when PFC Deadlock Recovery is triggered with SAI_PACKET_ACTION_DROP [uint64_t] */ |
There was a problem hiding this comment.
Is the meaning: /* Packets in the queue that are discarded when PFC Deadlock Recovery is triggered with SAI_PACKET_ACTION_DROP [uint64_t] */
There was a problem hiding this comment.
correct, updated the comment to match ur suggestion to make it more clear
|
@msherif1234 - could you please address the review comments? |
The newly stats will count packets already in queue before PFWD recovery happens once the queue is recovered they will be flushed out and counted today they don't show in any counters and disappear silently |
Signed-off-by: Mohamed S. Mahmoud <mmahmoud2201@gmail.com>
958fbed to
6093dc1
Compare
addressed new review comments |
rck-innovium
left a comment
rck-innovium
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments.
5 participants
Add PFC DLR deleted packets and bytes statistics to SAI queue attributes
Description:
This PR introduces two new SAI queue statistics attributes to support Priority Flow Control (PFC) Deadlock Recovery (DLR) diagnostics:
Purpose
When PFC DLR is enabled with SAI_PACKET_ACTION_DROP, these statistics track packets and bytes that are deleted during deadlock recovery operations. This provides essential visibility into traffic management behavior during PFC deadlock scenarios.
Rationale
These attributes follow the existing pattern established by SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS and complement the credit watchdog statistics by providing comprehensive deleted traffic metrics for PFC DLR operations.
Benefits