Split instcombine test file into one file per pattern (#519).#608
Closed
sishtiaq wants to merge 1 commit into
Closed
Split instcombine test file into one file per pattern (#519).#608sishtiaq wants to merge 1 commit into
sishtiaq wants to merge 1 commit into
Conversation
math-fehr
reviewed
May 20, 2026
Collaborator
math-fehr
left a comment
math-fehr
left a comment
There was a problem hiding this comment.
Thanks! I just left a comment about a missing test.test. Otherwise, can you also delete the current instcombine.mlir file as well? Then we can merge this!
| // CHECK: %{{.*}} = "llvm.mlir.constant"() <{"value" = 2 : i32}> : () -> i32 | ||
| // CHECK-NEXT: %{{.*}} = "test.test"() : () -> i32 | ||
|
|
||
| %mul_two = "llvm.mul"(%a, %two) : (i32, i32) -> i32 |
Collaborator
There was a problem hiding this comment.
Can you add the test.test operation here as well? Otherwise this might remove all operations in the future once we implement DCE.
Collaborator
|
Is this superceeded by #616 ? |
Collaborator
Author
Yes. I'll close this one. |
Collaborator
Author
|
Superceeded by #616. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split instcombine test file into one file per pattern (#519).