Skip to content

Implement a dependently-typed interface for RuntimeValue#560

Closed
math-fehr wants to merge 1 commit into
mainfrom
math-fehr/runtimevalue-dep
Closed

Implement a dependently-typed interface for RuntimeValue#560
math-fehr wants to merge 1 commit into
mainfrom
math-fehr/runtimevalue-dep

Conversation

@math-fehr
Copy link
Copy Markdown
Collaborator

This should allow us to use dependent types in the interpreter while still allowing to use a default, non-typed version.

@math-fehr math-fehr self-assigned this May 13, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VeIR Benchmarks

Details
Benchmark suite Current: 2821c03 Previous: 83b3f78 Ratio
add-fold-worklist/create 1867500 ns (± 95031) 2453000 ns (± 81778) 0.76
add-fold-worklist/rewrite 3419000 ns (± 71023) 4021000 ns (± 99772) 0.85
add-fold-worklist-local/create 1992000 ns (± 96001) 2376000 ns (± 109526) 0.84
add-fold-worklist-local/rewrite 2898000 ns (± 25056) 3418500 ns (± 166755) 0.85
add-zero-worklist/create 1860000 ns (± 79932) 2347500 ns (± 99924) 0.79
add-zero-worklist/rewrite 2191000 ns (± 93422) 2597000 ns (± 129210) 0.84
add-zero-reuse-worklist/create 1535500 ns (± 72756) 1970000 ns (± 210873) 0.78
add-zero-reuse-worklist/rewrite 1811000 ns (± 88497) 2173000 ns (± 427630) 0.83
mul-two-worklist/create 1863000 ns (± 62416) 2471000 ns (± 102479) 0.75
mul-two-worklist/rewrite 4832000 ns (± 63105) 5671000 ns (± 172515) 0.85
add-fold-forwards/create 1852000 ns (± 92547) 2357000 ns (± 91689) 0.79
add-fold-forwards/rewrite 2679000 ns (± 32605) 3079000 ns (± 67778) 0.87
add-zero-forwards/create 1850000 ns (± 31220) 2435000 ns (± 110076) 0.76
add-zero-forwards/rewrite 1711000 ns (± 20142) 2026000 ns (± 53167) 0.84
add-zero-reuse-forwards/create 1568000 ns (± 73319) 1967000 ns (± 86789) 0.80
add-zero-reuse-forwards/rewrite 1404000 ns (± 54178) 1604000 ns (± 13483) 0.88
mul-two-forwards/create 1857000 ns (± 85591) 2359000 ns (± 73207) 0.79
mul-two-forwards/rewrite 3287000 ns (± 44881) 3899000 ns (± 197238) 0.84
add-zero-reuse-first/create 1547000 ns (± 77864) 1991500 ns (± 110910) 0.78
add-zero-reuse-first/rewrite 9000 ns (± 447) 9000 ns (± 1262) 1
add-zero-lots-of-reuse-first/create 1542000 ns (± 25417) 2020000 ns (± 115813) 0.76
add-zero-lots-of-reuse-first/rewrite 762000 ns (± 11992) 919500 ns (± 149581) 0.83

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Collaborator

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@math-fehr math-fehr force-pushed the math-fehr/runtimevalue-dep branch 4 times, most recently from d6f6695 to 83dd221 Compare May 18, 2026 06:41
@math-fehr math-fehr force-pushed the math-fehr/runtimevalue-dep branch from 83dd221 to a94a644 Compare May 21, 2026 15:48
@math-fehr math-fehr force-pushed the math-fehr/runtimevalue-dep branch 3 times, most recently from e03bd3a to abf6761 Compare May 28, 2026 18:10
This checks that a `RuntimeValue` in the interpreter represents a valid value of a `TypeAttr`.
@math-fehr math-fehr force-pushed the math-fehr/runtimevalue-dep branch from abf6761 to 2821c03 Compare May 28, 2026 23:54
@math-fehr math-fehr closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants