[codex] Fix README banner asset stability#76
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/assets/readme-banner.jpg, outside the mirroreddocs/**tree..github/assets/**as an editable README-media location.Why
The old README pointed at
docs/assets/readme-banner.jpg. That path was inside mirrored docs output, so the sync bot pruned it when the upstream source tree no longer contained that file. The README then rendered a broken image.This PR intentionally favors a stable README over automatic banner freshness: the image can become visually outdated until someone deliberately replaces
.github/assets/readme-banner.jpg, but it should not break just because the generated docs mirror changes.Validation
.github/assets/readme-banner.jpgexists and is a 1200x300 JPEG.f34e3ff14e306d257dd5e8557a30d3c2f43d2620.git show --check --format=short HEAD.