Repository navigation
refactor(mcp): share the bundle client connection lifecycle - #122
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle MCP discovery, tool calls, and resource or prompt requests each managed their own connection cleanup. They now share one connection deadline and one place that waits for the request to settle and closes the client. This keeps stdio, SSE, and streamable HTTP on the same lifecycle while preserving operation-specific request parameters and results.
The real stdio fixture exercises tool arguments, resource URIs, prompt arguments, and capability-based tool generation. Focused tests check that a stalled connection closes before dispatch, and that an asynchronous request failure reaches the caller after cleanup.
Compatibility
This covers Claude Code and Codex bundle MCP clients. Transport construction, advertised capabilities, pagination budgets, cancellation signals, and the generated tool contract retain their existing behavior. The emitted bundle declarations matched the base revision byte for byte.
Verification