Skip to content

fix(ecosystem): stop labelling the placeholder logo as the item's logo - #815

Merged
LakshanSS merged 1 commit into
openchoreo:mainfrom
LakshanSS:fix/ecosystem-placeholder-logo-alt-text
Aug 10, 2026
Merged

fix(ecosystem): stop labelling the placeholder logo as the item's logo#815
LakshanSS merged 1 commit into
openchoreo:mainfrom
LakshanSS:fix/ecosystem-placeholder-logo-alt-text

Conversation

@LakshanSS

@LakshanSS LakshanSS commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Purpose

Stop labelling the placeholder logo as the item's logo

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Accessibility
    • Improved handling of placeholder plugin logos so they are treated as decorative by assistive technologies.
    • Preserved descriptive alternative text for valid plugin logos.

Walkthrough

The change distinguishes placeholder logos from loaded logos. Placeholder logos now use decorative accessibility attributes. Loaded logos retain descriptive alternative text.

Changes

Logo accessibility

Layer / File(s) Summary
Placeholder logo accessibility handling
src/components/PluginCard/PluginCard.tsx, src/pages/ecosystem/item.tsx
Both components track placeholder logo usage. Placeholder logos use empty alternative text and aria-hidden; loaded logos retain descriptive alternative text.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: rashadism

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the purpose but omits the required Related Issues and Checklist sections. Add the Related Issues and Checklist sections, and complete each checklist item that applies.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: preventing placeholder logos from being labelled as item logos.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Ecosystem items without a `logoUrl` (and items whose hotlinked logo fails
to load) fall back to the OpenChoreo mark. Both renderers still described
that image as `alt="<item name> logo"`, so screen readers, crawlers, and
search engines were told the OpenChoreo mark is the logo of items such as
"Logs - AWS CloudWatch", "Metrics - Azure Monitor", and "Tracing - Google
Cloud Trace". That is inaccurate, and it implies an association with those
vendors that does not exist.

The placeholder carries no information about the item, and the item name is
already in the adjacent heading, so mark it decorative instead: empty `alt`
plus `aria-hidden` when the fallback is in use. Real logos keep their
existing descriptive alt text.

Signed-off-by: LakshanSS <lakshan230897@gmail.com>
@LakshanSS
LakshanSS force-pushed the fix/ecosystem-placeholder-logo-alt-text branch from 4495130 to f682d2c Compare August 10, 2026 09:39
@LakshanSS
LakshanSS merged commit 29fcbad into openchoreo:main Aug 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants