fix(ecosystem): stop labelling the placeholder logo as the item's logo - #815
Merged
LakshanSS merged 1 commit intoAug 10, 2026
Merged
Conversation
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change distinguishes placeholder logos from loaded logos. Placeholder logos now use decorative accessibility attributes. Loaded logos retain descriptive alternative text. ChangesLogo accessibility
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ecosystem items without a `logoUrl` (and items whose hotlinked logo fails to load) fall back to the OpenChoreo mark. Both renderers still described that image as `alt="<item name> logo"`, so screen readers, crawlers, and search engines were told the OpenChoreo mark is the logo of items such as "Logs - AWS CloudWatch", "Metrics - Azure Monitor", and "Tracing - Google Cloud Trace". That is inaccurate, and it implies an association with those vendors that does not exist. The placeholder carries no information about the item, and the item name is already in the adjacent heading, so mark it decorative instead: empty `alt` plus `aria-hidden` when the fallback is in use. Real logos keep their existing descriptive alt text. Signed-off-by: LakshanSS <lakshan230897@gmail.com>
LakshanSS
force-pushed
the
fix/ecosystem-placeholder-logo-alt-text
branch
from
August 10, 2026 09:39
4495130 to
f682d2c
Compare
rashadism
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Stop labelling the placeholder logo as the item's logo