Skip to content

backport-v1.2: fix: allow selecting/copying text from expanded log and event rows (#746) - #747

Merged
stefinie123 merged 1 commit into
openchoreo:release-v1.2from
akila-i:release-v1.2
Aug 7, 2026
Merged

backport-v1.2: fix: allow selecting/copying text from expanded log and event rows (#746)#747
stefinie123 merged 1 commit into
openchoreo:release-v1.2from
akila-i:release-v1.2

Conversation

@akila-i

@akila-i akila-i commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Purpose

Backport of #746 to the release-v1.2 line. Resolves openchoreo/openchoreo#4429 for 1.2.

The expand/collapse handler covered the whole log/event row, expanded panel included, so the click completing a drag-select collapsed the row and discarded the selection — the full message and every metadata value were impossible to copy.

Goals

Let users select and copy the full message and metadata values from an expanded log or event row, without the row collapsing out from under them.

Approach

Clean cherry-pick of 6729dc3b — the patch content is byte-identical to what merged on main, with no conflicts (all six source files were identical between the two branches).

  • Move the expand/collapse handler from the row wrapper onto the summary row, leaving the expanded panel outside the click target
  • Move cursor: pointer onto the summary row to match, so the expanded panel reads as selectable text rather than as a button

Before/after recordings are on the original PR: #746

User stories

As a developer debugging a component, I can copy a pod name, container name, or the full log/event message out of the expanded row to paste into a search or a chat.

Release note

Fixed log and event rows in the Runtime Logs and Events views collapsing when text in the expanded panel was selected, which made the full message and metadata values impossible to copy.

Documentation

N/A — behavioural bug fix with no user-facing documentation impact.

Training

N/A

Certification

N/A — no certification impact for a UI interaction fix.

Automation tests

  • Unit tests

    One regression test added per component (LogEntry, EventEntry) asserting a click inside the expanded panel does not collapse the row. 25 tests pass across the two suites on this branch. Codecov reported all modified lines covered on fix: allow selecting/copying text from expanded log and event rows #746.

  • Integration tests

    N/A — covered by the unit tests above plus manual verification.

Security checks

Samples

N/A

Related PRs

Migrations (if applicable)

N/A

Test environment

macOS, Chrome. Verified manually on the Runtime Logs and component Events views.

Learning

The root cause was structural rather than behavioural: the click target enclosed the content it was meant to reveal. Moving the target removed the need for any drag-detection heuristic. A sweep of the other 15 Collapse users in the repo confirmed they all already render the panel as a sibling of the click target, so no other surface needed the change.

…penchoreo#746)

fix(observability): allow copying text from expanded log and event rows

The expand/collapse handler covered the whole row, expanded panel
included, so the click completing a drag-select collapsed the row and
discarded the selection — the full message and metadata values could
not be copied.

- Move the handler from the row wrapper to the summary row, leaving the
  expanded panel outside the click target
- Move `cursor: pointer` onto the summary row to match

Fixes openchoreo/openchoreo#4429

Signed-off-by: Akila-I <akila.99g@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7d47fb5-3238-4e6d-8c57-40b281e8a84b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@akila-i
akila-i marked this pull request as ready for review August 6, 2026 10:14
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@stefinie123
stefinie123 merged commit 904eb54 into openchoreo:release-v1.2 Aug 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants