Skip to content

chore(api): document OCI external-storage providers - #433

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-174
Oct 11, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-174

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Documents OCI as an external-storage provider in the API reference.

Changes

  • Describe the OCI tenancy OCID, region, and bucket fields.
  • Include OCI in external-storage request and response provider choices.

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 20:33
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 20:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T22:28:16.683427Z 844e386 New commits
🔒 Security Review ✅ Completed 2026-10-11T22:29:18.989481Z 844e386 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Castiron custom code

Evaluated main: 47df9766d29c970082e6b50b90c86d12c8657d19.

✅ No new custom-code files detected.

5 mixed files remain; 0 existing customizations changed.

Compared 47df9766d29c → 844e38607853. Generated baselines verified.

5 existing customizations unchanged
  • pkg/cmd/adminorganizationcertificate.go
  • pkg/cmd/audiovoice.go
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38180459572 --repo openai/openai-cli \
  --name castiron-custom-code-38180459572-1 --dir /tmp/castiron-custom-code-38180459572-1
git apply --stat /tmp/castiron-custom-code-38180459572-1/custom-code.patch
cat /tmp/castiron-custom-code-38180459572-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 47df9766d29c970082e6b50b90c86d12c8657d19 844e38607853c9e4ee0588698eed8b1fd334b766
python3 scripts/castiron/custom_code_report.py report \
  --base 47df9766d29c970082e6b50b90c86d12c8657d19 \
  --head 844e38607853c9e4ee0588698eed8b1fd334b766 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-844e38607853
cat /tmp/castiron-custom-code-844e38607853/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 2 changed files at 9e09cdbeb3c8c305e7aff0d7b2ee3844dfd0bfca.

No blocking findings. The reference adds two OCI schemas and includes them in the create, configuration-response, and audit provider unions. All four fields and requiredness agree with the Python, Node, and Ruby schema changes. Existing provider definitions remain unchanged.

The complete diff is limited to the API reference and generation metadata; no CLI runtime behavior changes.

I verified the full diff, immutable source hashes, merge base, and matching schema changes across all four SDK candidates. Exact-head CI reports 19 successful and 3 skipped checks, with 4 checks still running or queued. This was a source-only review; I did not run tests, builds, generation, or SDK execution.

@saioai

saioai commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

[saibot]

review pending. full review is queued or incomplete. no approval yet.

Castiron-Internal-PR: openai/openai-cli-internal#174
Castiron-Source-SHA: 46f1513b57927f0cd7415f0f1bfb3d59fc622dad
Castiron-Public-Base-SHA: 47df976
@jbeckwith-oai
jbeckwith-oai force-pushed the castiron/promotions/pr-174 branch from 9e09cdb to 844e386 Compare October 11, 2026 22:26
@jbeckwith-oai
jbeckwith-oai requested a review from a team October 11, 2026 22:27
@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 4f1f7df Oct 11, 2026
25 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-174 branch October 11, 2026 22:58
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants