Repository navigation
chore(api): document OCI external-storage providers - #433
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 5 mixed files remain; 0 existing customizations changed. Compared 5 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38180459572 --repo openai/openai-cli \
--name castiron-custom-code-38180459572-1 --dir /tmp/castiron-custom-code-38180459572-1
git apply --stat /tmp/castiron-custom-code-38180459572-1/custom-code.patch
cat /tmp/castiron-custom-code-38180459572-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 47df9766d29c970082e6b50b90c86d12c8657d19 844e38607853c9e4ee0588698eed8b1fd334b766
python3 scripts/castiron/custom_code_report.py report \
--base 47df9766d29c970082e6b50b90c86d12c8657d19 \
--head 844e38607853c9e4ee0588698eed8b1fd334b766 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-844e38607853
cat /tmp/castiron-custom-code-844e38607853/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all 2 changed files at 9e09cdbeb3c8c305e7aff0d7b2ee3844dfd0bfca.
No blocking findings. The reference adds two OCI schemas and includes them in the create, configuration-response, and audit provider unions. All four fields and requiredness agree with the Python, Node, and Ruby schema changes. Existing provider definitions remain unchanged.
The complete diff is limited to the API reference and generation metadata; no CLI runtime behavior changes.
I verified the full diff, immutable source hashes, merge base, and matching schema changes across all four SDK candidates. Exact-head CI reports 19 successful and 3 skipped checks, with 4 checks still running or queued. This was a source-only review; I did not run tests, builds, generation, or SDK execution.
|
[saibot] review pending. full review is queued or incomplete. no approval yet. |
Castiron-Internal-PR: openai/openai-cli-internal#174 Castiron-Source-SHA: 46f1513b57927f0cd7415f0f1bfb3d59fc622dad Castiron-Public-Base-SHA: 47df976
9e09cdb to
844e386
Compare
Summary
Documents OCI as an external-storage provider in the API reference.
Changes