refactor(ci): port source and test report checks to TypeScript - #768
refactor(ci): port source and test report checks to TypeScript#768kmbroai wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mldangelo-oai
left a comment
There was a problem hiding this comment.
TypeScript compilation, the source checker tests, and the report/workflow regression tests passed locally. No actionable findings in the port.
The current inventory-comparison failure reproduces with the original Python comparator on the same report and comes from duplicate test names already on main.
8ac81f7 to
29fe839
Compare
00c4719 to
0fe1165
Compare
mldangelo-oai
left a comment
There was a problem hiding this comment.
The port remains behaviorally sound. These two non-blocking simplifications remove custom filesystem/build plumbing and keep the checks closer to native Node and shell behavior.
Summary
Replace the portable-source checker and JUnit inventory comparator with typed TypeScript utilities. Compile them with the existing TypeScript compiler and run the emitted JavaScript on Node 22.13.0, removing these utilities' Python dependency without experimental type stripping.
Changes
.mtsfiles while preserving source limits, Markdown checks, tracked-file handling, JUnit outcomes, duplicate detection, and shard comparison.build:cito emit adjacent ignored.mjsfiles. Compile before running the utilities in CI and update contributor commands, regression tests, and development dependencies.sdk/typescript/tests-ts/finding-catalogue.test.ts,sdk/typescript/tests-ts/cli-workbench.test.ts, andsdk/typescript/tests-ts/cli.test.ts. Only their%stitle placeholders change to%p; fixtures, assertions, comparator behavior, and product code are unchanged.Testing
falseandtrueidentities for all four corrected pairs.git range-diff.Risk and rollout
The affected CI jobs install SDK development dependencies and compile the utilities before running them. Generated JavaScript is ignored and excluded from the published SDK. Test fixtures compile isolated copies so parallel runs do not share generated files. The comparator continues to reject duplicate identities; corrected titles expose existing parameter values without changing test behavior.
Public disclosure review