chore: resolve open dependabot security alerts - #418
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package manifest now requires Node.js ChangesMaintenance updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates JavaScript devDependencies/lockfile to address open Dependabot security alerts affecting transitive packages used by the markdown linting/tooling workflow.
Changes:
- Bumped
markdownlint-clidevDependency from^0.49.0to^0.49.1. - Updated
package-lock.jsonto pull patched transitive versions (includinglinkify-it,js-yaml, andbrace-expansion) and related dependency bumps.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Bumps markdownlint-cli to ^0.49.1 to pick up patched transitive dependencies. |
| package-lock.json | Refreshes the lockfile with updated transitive dependency versions (including security-related updates). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses Copilot review feedback on PR #418: markdownlint-cli 0.49.1's transitive deps (e.g. ini) require Node >=22, so declare engines.node to make the requirement explicit for contributors. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Pull request was converted to draft
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.markdown-link-check-config.json:11
- This unrelated exemption changes
markdown-link-checkbehavior by permanently skipping the existing CNCF invite link inspecification/appendix-c/index.md:19, although the PR is described as a dependency-only security update whose checks behave identically to main. Please remove it from this PR, or separately document why this URL must no longer be validated.
{
"pattern": ".*communityinviter.com/apps/cloud-native/cncf.*"
- js-yaml 3.15.0 -> 3.15.1 (high, alert #41) - js-yaml 4.3.0 -> 4.3.1 (high, alerts #40, #32) - linkify-it 5.0.1 -> 5.0.2 (high, alert #33) - brace-expansion 5.0.5 -> 5.0.9 (high, alert #31) - markdownlint-cli ^0.49.0 -> ^0.49.1 and node engines >=22.22.2 to pull in patched transitive deps Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
8f36e27 to
9eb8188
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
package.json:5
- This range is broader than the tooling actually supports. In particular, it accepts Node 23, Node 25, and Node 24.0–24.14, while the newly locked
ini@7.0.0declares^22.22.2 || ^24.15.0 || >=26.0.0(package-lock.json:841). Those versions will therefore satisfy the repository contract but trigger an engine mismatch duringnpm ci(or fail withengine-strict). Match the root range to the tightest transitive requirement.
"node": ">=22.22.2"
Summary
Dependabot Alerts Resolved
js-yamljs-yamllinkify-itjs-yamlbrace-expansionAlso bumped
markdownlint-clidevDependency to^0.49.1and declaredengines.node >=22.22.2to keep dev tooling versions explicit and in sync with the transitive dependency requirements pulled in by the lockfile refresh.Verified with
npm audit(0 vulnerabilities) and by runningmake lint/make markdown-toclocally, matching CI.