Repository navigation
Conversation
wang-kaopu
force-pushed
the
codex/preserve-fence-tail-418
branch
from
November 6, 2026 05:59
67bb6a9 to
0eda442
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a response places explanation text after a complete JSON value but before the closing dsh-ui fence (or omits the closing fence), the renderer previously adopted the JSON prefix, hid the whole source block, and silently hid the explanation. The same prefix-only repair could be returned by validate_dsh_ui as replacement JSON.
Repair now reports unconsumed source text. Settled rendering keeps the entire original block visible with a localized diagnostic, validation refuses a lossy replacement, and bounded feedback requests both the corrected fence and preserved text. A valid unclosed JSON body remains renderable; normal replies and progressive streaming are unchanged. Generic-label diagnostics use the same ownership rules as takeover. No prompt or component-selection rules are changed.
Issue #420 is also fixed: the tier-2 quote scanner now closes a malformed object key at its matching object delimiter, preserving the missing-colon JSON error and preventing later keyvalue pairs or sibling components from being absorbed into the key. Regression tests cover the reported sample with and without following sibling components, including validate_dsh_ui diagnostics.
Validation:
Related to #418. Fixes #420. This fixes a confirmed synthetic content-loss path for #418, not a confirmed diagnosis of that reporter's original session. Keep #418 open pending the original sample or reporter retest.