Skip to content
This repository was archived by the owner on Oct 29, 2021. It is now read-only.

Issue: 87 Adding gzip support for all requests#90

Open
Rushit wants to merge 1 commit into
olebedev:masterfrom
Rushit:gzip
Open

Issue: 87 Adding gzip support for all requests#90
Rushit wants to merge 1 commit into
olebedev:masterfrom
Rushit:gzip

Conversation

@Rushit

@Rushit Rushit commented Jun 7, 2017

Copy link
Copy Markdown

This will add support for gzip to address - #87

@olebedev

@olebedev

olebedev commented Jun 8, 2017

Copy link
Copy Markdown
Owner

Hi @Rushit, thanks for the contribution!
Did you see that tests have failed? It seems we have to make test passing, anyway.

@Rushit

Rushit commented Jun 8, 2017

Copy link
Copy Markdown
Author

@olebedev I will fix the tests on this PR.

@iKonrad

iKonrad commented Jun 8, 2017

Copy link
Copy Markdown

Thanks man! I eventually got gzip working with echo's gzip middleware, but to do that I had to move bundle.js away from the binary.

Is there any reason from performance point of view to keep bundle.js in bindata?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants