[seekdb][memory] Add main memory module statistics view - #1306
Open
hnwyllmm wants to merge 1 commit into
Open
Conversation
Member
Author
|
The mapping Dima issue is to add memory statistics views for each major memory module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Existing
__all_virtual_memory_info/V$OB_MEMORYrely on obmalloc label statistics, making it impossible to intuitively display the memory usage and limits of main modules after obmalloc is removed.Solution Description
Adjusted
__all_virtual_memory_infoandV$OB_MEMORYto have four columns: MOD_NAME, HOLD, USED, MEM_LIMIT, fixed to aggregate 12 modules: KV Cache, Plan/PS Cache, MemStore, TX_DATA, MDS, Storage Meta, Schema, Vector, SQL Workarea, DTL, and Tmp File. Added a narrow-scope module getter, preserving the native statistical scope of each module. Modules without a valid limit return NULL, and no default ordering is provided. Migrated existing tests/golden files and cleaned up isolated results and assertions that depended on the old label statistics.Passed Regressions
__all_virtual_ps_statis consistentUpgrade Compatibility
Directly replaces the old obmalloc virtual table contract, deleting old fields like ctx/label/count. Queries dependent on the old fields need to migrate to the new four-column module aggregation interface.
Other Information
This MR only contains commit 03a64f8fa00; 2 untracked files are not within the review scope.
V$OB_MEMORYdoes not guarantee a default row order.Release Note