[seekdb][PALF] Remove LogGroupBuffer copy from transaction log flush - #1253
Open
hnwyllmm wants to merge 1 commit into
Open
[seekdb][PALF] Remove LogGroupBuffer copy from transaction log flush#1253hnwyllmm wants to merge 1 commit into
hnwyllmm wants to merge 1 commit into
Conversation
Member
Author
|
The mapping Dima issue is about optimizing LogGroupBuffer and LogDIOAligned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Transaction logs are serialized into ObTxLogBlock, copied into the shared 4 MiB LogGroupBuffer, and copied again into LogDIOAlignedBuf before pwrite. The first large copy adds memory-bandwidth cost and couples pending-write ownership, group assembly, flow control, and Hot Cache.
Solution Description
Passed Regressions
Upgrade Compatibility
No on-disk log format change. The legacy append API remains compatible. Hot Cache is disabled in this version, which may affect cache-hit performance but does not change read semantics because reads fall back to disk.
Other Information
This MR contains one commit, 5f93727510d, with no unrelated commits or untracked files.
Release Note