Workspace 1074 2

[SKairinos]

This change is 

[faucomte97]

@faucomte97 reviewed 8 files and all commit messages, and made 7 comments.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on SKairinos).

---

.github/actions/deploy_gcloud/action.yml line 7 at r2 (raw file):

    description: App ID
    required: true
  module-name:

Is this still needed?

---

.github/workflows/deploy_default.yml line 14 at r2 (raw file):

      NODE_ENV: production
      DB_PORT: 5432
      MODULE_NAME: default

Is this still needed?

---

.github/workflows/deploy_default.yml line 45 at r2 (raw file):

          # Local environment variables.
          app-id: ${{ env.APP_ID }}
          module-name: ${{ env.MODULE_NAME }}

Is this still needed?

---

.github/workflows/deploy_dev.yml line 24 at r2 (raw file):

      NODE_ENV: production
      DB_PORT: 5432
      MODULE_NAME: dev

Is this still needed?

---

.github/workflows/deploy_dev.yml line 55 at r2 (raw file):

          # Local environment variables.
          app-id: ${{ env.APP_ID }}
          module-name: ${{ env.MODULE_NAME }}

Is this still needed?

---

.github/workflows/deploy_staging.yml line 14 at r2 (raw file):

      NODE_ENV: production
      DB_PORT: 5432
      MODULE_NAME: staging

Is this still needed?

---

.github/workflows/deploy_staging.yml line 45 at r2 (raw file):

          # Local environment variables.
          app-id: ${{ env.APP_ID }}
          module-name: ${{ env.MODULE_NAME }}

Is this still needed?

[SKairinos]

@SKairinos made 7 comments.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on faucomte97).

---

.github/actions/deploy_gcloud/action.yml line 7 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this still needed?

I believe so, yes. It's used as for the cache prefix. see

---

.github/workflows/deploy_default.yml line 14 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this still needed?

see response

---

.github/workflows/deploy_default.yml line 45 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this still needed?

see response

---

.github/workflows/deploy_dev.yml line 24 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this still needed?

see response

---

.github/workflows/deploy_dev.yml line 55 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this still needed?

see response

---

.github/workflows/deploy_staging.yml line 14 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this still needed?

see response

---

.github/workflows/deploy_staging.yml line 45 at r2 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Is this still needed?

see response

[faucomte97]

@faucomte97 made 1 comment and resolved 7 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on SKairinos).