#142: Make integer overflow semantics explicit - #144
Open
zaguzovmaksim0-hue wants to merge 1 commit into
Open
zaguzovmaksim0-hue wants to merge 1 commit into
zaguzovmaksim0-hue wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 94.09% 94.11% +0.02%
==========================================
Files 14 14
Lines 711 714 +3
==========================================
+ Hits 669 672 +3
Misses 42 42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142.
The four integer atoms whose plain
i16arithmetic changed behavior between debug and release builds now use explicit two's-complement wrapping operations:wrapping_add,wrapping_sub,wrapping_mul, andwrapping_neg.This preserves the release-mode arithmetic result while removing the debug-only overflow panic. It also fits the current
Atom = fn(...) -> Option<Data>contract:Nonemeans that an input is not yet dataized, so usingchecked_*and returningNonefor arithmetic overflow would incorrectly make overflow look like a missing operand and could leave the emulator stuck.Regression tests cover all four boundaries, including
i16::MAX + 1and negation ofi16::MIN.Validation on Android/Termux:
cargo fmt -- --check— passed;cargo test --all-targets— passed;cargo clippy --all-targets --all-features -- -D warnings— passed;git diff --check— clean.