Feat/add response validation middleware#13
Open
zucchinho wants to merge 3 commits intooapi-codegen:mainfrom
Open
Feat/add response validation middleware#13zucchinho wants to merge 3 commits intooapi-codegen:mainfrom
zucchinho wants to merge 3 commits intooapi-codegen:mainfrom
Conversation
Move shared code into types and utils files Add proper types for context keys to get rid of linter warning
Remove case for SecurityRequirementsError Improve test coverage
Author
|
any chance of a review on this? |
Member
|
Will come back to it after the release of v2.2.0 for oapi-codegen, which should be next couple of days :) |
Author
@jamietanna did the update to 2.2.0 go smoothly? i appear to acquired some conflicts here as a result, any use resolving these now or should i wait for v2 to stabilize? |
|
Just wanted to check-in on this. Looking for the same functionality, and before I pulled a fork, was looking to see if this could be pulled in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OapiResponseValidatorfollows largely the same pattern as theOapiRequestValidator. A key difference is that the validation happens after the handler chain has been invoked, and it is obviously the response we are validating.A wrapper around the underlying
gin.ResponseWriteris needed to capture the response content. If the response is valid, it is written to the underlying writer.In the case of bad responses, a 500 status code is returned.
If the route is not recognized, a 404 is returned.
Where feasible, common code is now shared between the 2 middlewares. This also facilitates creating a hybrid middleware which validates both requests and responses at some point in the future.