Repository navigation
docs(code): require a Given section in every test - #7
Merged
Merged
Conversation
The marker table let `//* Given` be omitted when a test constructed nothing, which put the literal the case turns on inline in `//* When` beside the call under test; a test always has a precondition, and naming it is what keeps the two apart. - Mark `//* Given` required and say where the bare constants and literals go when there is nothing to construct. - Replace the example that omitted the marker with one binding its input to a named local, which also ports it off the unrelated types it was carrying. - Split the checklist item so the presence of all three markers and the no-setup case are ticked separately. Signed-off-by: Lorenzo Delgado <lnsdev@proton.me>
LNSD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The marker table let
//* Givenbe omitted when a test constructed nothing, which put the literal the case turns on inline in//* Whenbeside the call under test; a test always has a precondition, and naming it is what keeps the two apart.//* Givenrequired and say where the bare constants and literals go when there is nothing to construct.