Repository navigation
docs: teach the skills the configuration they are meant to prove - #11
Merged
Merged
Conversation
The check skill named a feature that no longer exists and gave a `no-std` command that compiles neither the builders nor most of the formats, so an agent following it would report the bare-metal configuration clean without having built the layer where a `use std::` actually creeps in. - Point both `no-std` invocations at the flags CI uses, `--no-default-features --features all-formats,alloc --target aarch64-unknown-none`, so the local check and the gating one are the same check. - Restate the signals that call for the second configuration in terms of a `std` gate, and add `src/write/` to them: the builders are now compiled without `std`, so they can break there too. - Correct the test and review skills, which described the suite and the compatibility rule by the same removed feature. Signed-off-by: Lorenzo Delgado <lnsdev@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check skill named a feature that no longer exists and gave a
no-stdcommand that compiles neither the builders nor most of the formats, so an agent following it would report the bare-metal configuration clean without having built the layer where ause std::actually creeps in.no-stdinvocations at the flags CI uses,--no-default-features --features all-formats,alloc --target aarch64-unknown-none, so the local check and the gating one are the same check.stdgate, and addsrc/write/to them: the builders are now compiled withoutstd, so they can break there too.