Skip to content

test: check our types + run attw/publint on example - #834

Merged
danielroe merged 2 commits into
mainfrom
chore/pack-checks
Nov 16, 2026
Merged

danielroe merged 2 commits into
mainfrom
chore/pack-checks

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

@pkg-pr-new

pkg-pr-new Bot commented Nov 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nuxt/module-builder/@nuxt/module-builder@834

commit: 301b7e7

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI lint job replaces separate published-types and package-metadata checks with pnpm test:pack. This script packs the example into .temp-pack/example.tgz and runs attw and publint against the archive. The attw configuration now uses the strict profile. Its error level and ignored rule remain unchanged.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · up to 301b7

This change only adjusts CI package checks and has no effect on runtime behavior. The risk of merging is minimal.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description is only the unfilled template from the Nuxt contribution guidelines. It has no text describing the changes. Still, it is not off-topic, and the check is lenient. The linked issue and d… Add a short description of the change. Explain why the packed-types and package.json checks replace the earlier attw and publint scripts, and mention any linked issue.
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the two main changes: type checks for the project's own types and attw/publint runs on the packed example. The changeset matches this. It is a conventional commit with a 'test:' prefix…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes: type checks for the project's own types and attw/publint runs on the packed example. The changeset matches this. It is a conventional commit with a 'test:' prefix and is specific enough for a teammate to scan.

Full details: Description check

Explanation

The description is only the unfilled template from the Nuxt contribution guidelines. It has no text describing the changes. Still, it is not off-topic, and the check is lenient. The linked issue and description placeholders are empty.

Resolution

Add a short description of the change. Explain why the packed-types and package.json checks replace the earlier attw and publint scripts, and mention any linked issue.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ee362f30-b7bd-48e8-bbb8-9e4ef3a4106f
Commits

Reviewing files that changed from the base of the PR and between b8843aa and 301b7e7.

Files selected for processing: 3

  • .github/workflows/ci.yml
  • package.json
  • tsdown.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@danielroe
danielroe added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit c9fa589 Nov 16, 2026
14 checks passed
@danielroe
danielroe deleted the chore/pack-checks branch November 16, 2026 22:32
@github-actions github-actions Bot mentioned this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant