Skip to content

ci: update ci workflow - #830

Merged
danielroe merged 1 commit into
nuxt:mainfrom
userquin:update-ci-workflow
Nov 13, 2026
Merged

danielroe merged 1 commit into
nuxt:mainfrom
userquin:update-ci-workflow

Conversation

@userquin

@userquin userquin commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked issue

NA

📚 Description

This PR updates the ci workflow:

  • don't run CI jobs on release pr (only at main and v1 branches, PR or merge groups)
  • protect checkout: checkout actions running with persist-credentials: false

@userquin
userquin requested a review from danielroe as a code owner November 13, 2026 19:09
@pkg-pr-new

pkg-pr-new Bot commented Nov 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nuxt/module-builder/@nuxt/module-builder@830

commit: c0ed64c

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The lint, ci, and engines-floor jobs now run for pushes to the default branch or v1, pull requests whose head branch does not start with release/v, and GitHub merge-group events. Each job’s checkout step sets persist-credentials to false.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to c0ed6

This change narrows when CI jobs run and stops checkout from persisting credentials. It does not affect application behavior, and no merge-blocking risk was found.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "ci: update ci workflow" follows conventional commits and names the right area, the CI workflow. It is vague, though. It does not say what changed. The PR limits the lint, ci and engines-flo… Replace the generic phrase with a title that names the main change. For example: "ci: skip CI jobs for release PRs and disable persisted checkout credentials" or "ci: limit CI jobs to main, v1, and merge groups".
Passed Passed checks: 3 passed

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states that the PR updates the CI workflow. It says CI jobs will not run on release PRs and will run only on the main and v1 branches, on PRs, and on merge groups. It also says checkou…
Full details: Description check

Explanation

The description states that the PR updates the CI workflow. It says CI jobs will not run on release PRs and will run only on the main and v1 branches, on PRs, and on merge groups. It also says checkout actions will use persist-credentials: false. These points match the raw summary of the changes to .github/workflows/ci.yml.

Full details: Title check

Explanation

The title "ci: update ci workflow" follows conventional commits and names the right area, the CI workflow. It is vague, though. It does not say what changed. The PR limits the lint, ci and engines-floor jobs to the default branch, v1, and merge groups, skips release PRs, and sets persist-credentials to false on checkout steps. The title does not mention either change, so it is non-descriptive for a teammate scanning history.

Resolution

Replace the generic phrase with a title that names the main change. For example: "ci: skip CI jobs for release PRs and disable persisted checkout credentials" or "ci: limit CI jobs to main, v1, and merge groups".

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fd487ae7-0631-45d7-9023-96f64a7f6675
Commits

Reviewing files that changed from the base of the PR and between 0f7e33d and c0ed64c.

Files selected for processing: 1

  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@danielroe
danielroe added this pull request to the merge queue Nov 13, 2026
Merged via the queue into nuxt:main with commit c642799 Nov 13, 2026
11 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 13, 2026
@userquin
userquin deleted the update-ci-workflow branch November 13, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants