You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: keep value exports as values in types.d.mts - #826
No actionable comments were generated in the recent review.
Walkthrough
Declaration generation now distinguishes type-only exports from value exports. It marks named re-exports as type-only only when their names are classified as type-only. New build tests cover function and constant exports in regular and isolated-declaration variants. They compare generated declarations and type-check a consumer that imports the values and ModuleOptions.
Generated type declarations should now re-export values as values and mark only real types as type. No concrete merge-blocking risk was identified, and new build tests cover the changed behavior.
Pre-merge checks: 4
Check name
Status
Explanation
Description check
The description states that value exports, including default, are re-exported as values, and that only type exports such as interfaces and type aliases are marked as type. This matches the changes in …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title names the primary change: value exports in types.d.mts are kept as values rather than marked as types. The raw summary confirms that writeTypes now applies the type modifier only to type-onl…
Full details: Description check
Explanation
The description states that value exports, including default, are re-exported as values, and that only type exports such as interfaces and type aliases are marked as type. This matches the changes in src/build/types.ts and the new test in test/build.spec.ts. The linked issue section is left as template placeholder text, but the description is related to the changeset.
Full details: Title check
Explanation
The title names the primary change: value exports in types.d.mts are kept as values rather than marked as types. The raw summary confirms that writeTypes now applies the type modifier only to type-only names, and the new test checks that function and constant re-exports are not marked as types. The title is concise, specific, and follows the conventional commit style. It does not mention the isolatedDeclarations test fixtures, which is acceptable because the title needs to cover only the main change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: fc4016e2-54b2-4ca7-8cd4-9ab60d947baa
Commits
Reviewing files that changed from the base of the PR and between 05863cb and 599b65d.
Files selected for processing: 2
src/build/types.ts
test/build.spec.ts
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
this re-exports value exports, including
default, as values, and keeps only type exports such as interfaces and type aliases astype.