Skip to content

chore: fix test:engines on Windows - #823

Merged
danielroe merged 1 commit into
nuxt:mainfrom
userquin:chore-fix-test-engines-on-windows
Nov 13, 2026
Merged

danielroe merged 1 commit into
nuxt:mainfrom
userquin:chore-fix-test-engines-on-windows

Conversation

@userquin

@userquin userquin commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #822

📚 Description

This PR uses pnpm exec to run installed-check at test:engines script.

At CI only tested on linux.

@userquin
userquin requested a review from danielroe as a code owner November 13, 2026 16:22
@pkg-pr-new

pkg-pr-new Bot commented Nov 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nuxt/module-builder/@nuxt/module-builder@823

commit: 848df2d

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The test:engines script now invokes installed-check through pnpm exec. Its flags and arguments are unchanged.

Estimated code review effort: 2 (Simple) | ~5 minutes

Severity of issue fixed: Low

Merge Risk: Minimal · up to 848df

This change makes the engine-check script run through pnpm so it works on Windows. It has no effect on the published package, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title says the PR fixes test:engines on Windows. The change runs installed-check through pnpm exec in the test:engines script, so the title matches the main change. It uses the conventional 'chore…
Linked Issues check Passed Issue #822 requires running installed-check through pnpm exec or pnpm dlx so that test:engines works on Windows. The reviewed head package.json sets `"test:engines": "pnpm exec installed-che…
Out of Scope Changes check Passed The PR changes one line in package.json, the test:engines script. The change directly implements issue #822. It does not alter other scripts, dependencies, or exports. No out-of-scope change was f…
Description check Passed The description relates to the changeset. It states that the PR uses pnpm exec to run installed-check in the test:engines script, which matches the package.json change in the raw summary. It also link…
Full details: Title check

Explanation

The title says the PR fixes test:engines on Windows. The change runs installed-check through pnpm exec in the test:engines script, so the title matches the main change. It uses the conventional 'chore:' prefix. The title does not name the mechanism, but it is specific enough for a reviewer scanning history.

Full details: Linked Issues check

Explanation

Issue #822 requires running installed-check through pnpm exec or pnpm dlx so that test:engines works on Windows. The reviewed head package.json sets "test:engines": "pnpm exec installed-check -d -i tsdown --no-workspaces --ignore @nuxt/cli", which meets the requirement. The PR summary reports a +1/-1 change to this script with arguments unchanged. The change is a script declaration, so no automated test applies. The base blob could not be read, so the before-state rests on the PR summary.

Full details: Out of Scope Changes check

Explanation

The PR changes one line in package.json, the test:engines script. The change directly implements issue #822. It does not alter other scripts, dependencies, or exports. No out-of-scope change was found in the supplied summary or the reviewed head file.

Full details: Description check

Explanation

The description relates to the changeset. It states that the PR uses pnpm exec to run installed-check in the test:engines script, which matches the package.json change in the raw summary. It also links issue #822 and notes that CI tests only on Linux. The template text is left in place, but the core description is specific enough to pass this lenient check.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41c69b15-02c2-4a8e-b94b-cef8d257bbc7
Commits

Reviewing files that changed from the base of the PR and between f9f9367 and 848df2d.

Files selected for processing: 1

  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@danielroe
danielroe merged commit 05863cb into nuxt:main Nov 13, 2026
11 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 13, 2026
@userquin
userquin deleted the chore-fix-test-engines-on-windows branch November 13, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run test:engines script on Windows

2 participants