You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review.
Walkthrough
The TypeScript configuration now targets ES2024, removes allowJs, uses lowercase module settings, and enables isolatedDeclarations. Build and Rolldown declarations gain explicit types. Two Rolldown functions are newly exported. The build and prepare commands now use typed command definitions. The described function implementations and command behaviour remain unchanged.
This change enables isolated declarations by adding explicit types and updating the TypeScript configuration. Runtime behavior is not expected to change, and no concrete merge-blocking risk was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title 'perf: enable isolatedDeclarations' matches the main change. The PR enables isolatedDeclarations in tsconfig.json and adds explicit return types and exported annotations across src/build, …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description links to no issue and gives one sentence: it enables isolatedDeclarations for faster declaration builds and notes that switching to es2024 is safe. This matches the changeset, which ad…
Full details: Title check
Explanation
The title 'perf: enable isolatedDeclarations' matches the main change. The PR enables isolatedDeclarations in tsconfig.json and adds explicit return types and exported annotations across src/build, src/commands and src/rolldown to support it.
Full details: Description check
Explanation
The description links to no issue and gives one sentence: it enables isolatedDeclarations for faster declaration builds and notes that switching to es2024 is safe. This matches the changeset, which adds explicit return types and sets isolatedDeclarations: true with the es2024 target in tsconfig.json. The description is related to the changes, so the check passes.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: abf2733f-8fa0-4070-af5e-aefa5c471d7e
Commits
Reviewing files that changed from the base of the PR and between 19155fe and 7e03c5c.
Files selected for processing: 20
src/build/advice.ts
src/build/aliases.ts
src/build/build-config.ts
src/build/build.ts
src/build/deprecations.ts
src/build/externals.ts
src/build/loader.ts
src/build/meta.ts
src/build/stub.ts
src/build/tsconfig.ts
src/build/types.ts
src/commands/_shared.ts
src/commands/build.ts
src/commands/prepare.ts
src/rolldown/declarations.ts
src/rolldown/resolve.ts
src/rolldown/stylesheets.ts
src/rolldown/tsconfig.ts
src/rolldown/vue.ts
tsconfig.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
Enables
isolatedDeclarationsfor faster declaration builds. (It's safe to switch toes2024too.)