Skip to content

perf: enable isolatedDeclarations - #816

Merged
danielroe merged 1 commit into
nuxt:mainfrom
DamianGlowala:perf/isolated-declarations
Nov 12, 2026
Merged

danielroe merged 1 commit into
nuxt:mainfrom
DamianGlowala:perf/isolated-declarations

Conversation

@DamianGlowala

@DamianGlowala DamianGlowala commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

Enables isolatedDeclarations for faster declaration builds. (It's safe to switch to es2024 too.)

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nuxt/module-builder/@nuxt/module-builder@816

commit: 7e03c5c

@danielroe danielroe left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

practise what we preach!

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The TypeScript configuration now targets ES2024, removes allowJs, uses lowercase module settings, and enables isolatedDeclarations. Build and Rolldown declarations gain explicit types. Two Rolldown functions are newly exported. The build and prepare commands now use typed command definitions. The described function implementations and command behaviour remain unchanged.

Estimated code review effort: 2 (Simple) | ~12 minutes

Merge Risk: Minimal · up to 7e03c

This change enables isolated declarations by adding explicit types and updating the TypeScript configuration. Runtime behavior is not expected to change, and no concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title 'perf: enable isolatedDeclarations' matches the main change. The PR enables isolatedDeclarations in tsconfig.json and adds explicit return types and exported annotations across src/build, …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description links to no issue and gives one sentence: it enables isolatedDeclarations for faster declaration builds and notes that switching to es2024 is safe. This matches the changeset, which ad…
Full details: Title check

Explanation

The title 'perf: enable isolatedDeclarations' matches the main change. The PR enables isolatedDeclarations in tsconfig.json and adds explicit return types and exported annotations across src/build, src/commands and src/rolldown to support it.

Full details: Description check

Explanation

The description links to no issue and gives one sentence: it enables isolatedDeclarations for faster declaration builds and notes that switching to es2024 is safe. This matches the changeset, which adds explicit return types and sets isolatedDeclarations: true with the es2024 target in tsconfig.json. The description is related to the changes, so the check passes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: abf2733f-8fa0-4070-af5e-aefa5c471d7e
Commits

Reviewing files that changed from the base of the PR and between 19155fe and 7e03c5c.

Files selected for processing: 20

  • src/build/advice.ts
  • src/build/aliases.ts
  • src/build/build-config.ts
  • src/build/build.ts
  • src/build/deprecations.ts
  • src/build/externals.ts
  • src/build/loader.ts
  • src/build/meta.ts
  • src/build/stub.ts
  • src/build/tsconfig.ts
  • src/build/types.ts
  • src/commands/_shared.ts
  • src/commands/build.ts
  • src/commands/prepare.ts
  • src/rolldown/declarations.ts
  • src/rolldown/resolve.ts
  • src/rolldown/stylesheets.ts
  • src/rolldown/tsconfig.ts
  • src/rolldown/vue.ts
  • tsconfig.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@danielroe
danielroe merged commit d007926 into nuxt:main Nov 12, 2026
11 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants