Conversation
| "default", | ||
| "modern" | ||
| "modern", | ||
| "template" |
There was a problem hiding this comment.
Maybe call this npgsql_template to make it clearer it's our customizations etc.
| @@ -0,0 +1,46 @@ | |||
| {{!Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.}} | |||
|
|
|||
| <head> | |||
There was a problem hiding this comment.
Just noting that this override means we need to react if there are any upstream changes in the modern template... This is what caused things when I was upgrading things, which is why I removed it.
I'm hoping maybe there's some way to just add our favicons rather than replacing the entire <head>, which seems like it could cause similar trouble in the future... Is something like that possible, like some more targeted partial or extensibility hook specifically for favicon?
There was a problem hiding this comment.
I'm hoping maybe there's some way to just add our favicons rather than replacing the entire
Not out of the box. That would be an upstream PR to docfx.
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
OK!
Yeah, good favicon support could be a nice thing to contribute to the upstream template, if you feel like doing that kind of work! Otherwise OK to merge for this.
2 participants
With the recent docfx update we lost some advanced favicon features.
This brings them back and also updates them with regards to additional featuress.