sdk(local_relay): InnerLocalRelay::handle_connection take conn permit before handshake - #1458
Merged
yukibtc merged 1 commit intoSep 19, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TheAwiteb
added a commit
to TheAwiteb/nostr
that referenced
this pull request
Aug 21, 2026
Returns the number of remaining connections the relay can handle. Useful for relays that use `LocalRelay::take_connection` with an already upgraded connection, avoiding CPU waste on connections that would be rejected due to capacity limits. Refs nostrdevkit#1458 Signed-off-by: Awiteb <a@4rs.nl>
3 tasks
…it before handshake I don't really think any relay use `handle_connection`, as I know all of them use `handle_upgraded_connection`, which take an already upgraded connection. But just in case a prodaction realy used it. Pull-Request: nostrdevkit#1458 Signed-off-by: Awiteb <a@4rs.nl> Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
yukibtc
force-pushed
the
local-relay-run-take-conn-permit-first
branch
from
September 19, 2026 06:59
25ca2d2 to
1e855b2
Compare
yukibtc
approved these changes
Sep 19, 2026
yukibtc
pushed a commit
to TheAwiteb/nostr
that referenced
this pull request
Sep 19, 2026
Returns the number of remaining connections the relay can handle. Useful for relays that use `LocalRelay::take_connection` with an already upgraded connection, avoiding CPU waste on connections that would be rejected due to capacity limits. Refs nostrdevkit#1458 Pull-Request: nostrdevkit#1459 Signed-off-by: Awiteb <a@4rs.nl>
yukibtc
pushed a commit
that referenced
this pull request
Sep 19, 2026
…it before handshake I don't really think any relay use `handle_connection`, as I know all of them use `handle_upgraded_connection`, which take an already upgraded connection. But just in case a prodaction realy used it. Pull-Request: #1458 Signed-off-by: Awiteb <a@4rs.nl> Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com> (cherry picked from commit 1e855b2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really think any relay use
handle_connection, as I know all of them usehandle_upgraded_connection, which take an already upgraded connection. But just in case a prodaction realy used it.Checklist
CHANGELOG.md(if applicable)