Skip to content

tools: respect 7 days wait commit-queue with one approval #62498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panva wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Open

tools: respect 7 days wait commit-queue with one approval #62498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b54cf5d
tools: respect 7 days wait commit-queue with one approval
panva Mar 29, 2026
83c3b3f
fixup! tools: respect 7 days wait commit-queue with one approval
panva Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tools/actions/commit-queue.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,17 @@ for pr in "$@"; do
continue
fi

# Skip PR if it has only one approval and was created less than 7 days ago
pr_meta=$(gh pr view "$pr" --json reviews,createdAt)
approvals=$(echo "$pr_meta" | jq '[.reviews[] | select(.state == "APPROVED" and .authorAssociation == "MEMBER")] | unique_by(.author.login) | length')
created_at=$(echo "$pr_meta" | jq -r '.createdAt')
created_epoch=$(date -d "$created_at" +%s)
seven_days_ago=$(date -d "7 days ago" +%s)
if [ "$approvals" -le 1 ] && [ "$created_epoch" -gt "$seven_days_ago" ]; then
echo "pr ${pr} skipped, only one approval and created less than 7 days ago"
continue
fi

# Delete the commit queue label
gh pr edit "$pr" --remove-label "$COMMIT_QUEUE_LABEL"

Expand Down
Loading