crypto: decorate async crypto job errors with OpenSSL error details#62348
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 28, 2026
Merged
Conversation
panva
requested review from
RafaelGSS,
addaleax,
bnoordhuis,
jasnell and
tniessen
panva
added
crypto
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
approved these changes
Mar 20, 2026
panva
added
the
author ready
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #62348 +/- ##
=======================================
Coverage 89.70% 89.70%
=======================================
Files 678 678
Lines 207260 207278 +18
Branches 39749 39744 -5
=======================================
+ Hits 185917 185949 +32
+ Misses 13443 13434 -9
+ Partials 7900 7895 -5
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Mar 20, 2026
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
cc @nodejs/tsc for semver-major signoff |
panva
removed
the
commit-queue-failed
panva
force-pushed
the
crypto-async-error-decoration
branch
from
6be5eb0 to
c5653bf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Mar 27, 2026
jasnell
approved these changes
Mar 27, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 74509b1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance CryptoErrorStore to preserve OpenSSL error details (code, library, reason) on errors from async crypto operations, restoring parity with the errors thrown synchronously.
This is the semver-majorPRs that contain breaking changes and should be released in the next major version.
follow up to a fix made in 5eeb9f3