sqlite: add sqlite prepare options args #61311

araujogui · 2026-01-08T01:44:47Z

nodejs-github-bot · 2026-01-08T01:44:51Z

Review requested:

@nodejs/sqlite

codecov · 2026-01-08T02:48:06Z

Codecov Report

❌ Patch coverage is 84.81013% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (58f5da2) to head (1fa1c8a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	84.81%	7 Missing and 5 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61311   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         704      704           
  Lines      208884   208963   +79     
  Branches    40334    40347   +13     
=======================================
+ Hits       184889   184970   +81     
- Misses      15966    15979   +13     
+ Partials     8029     8014   -15

Files with missing lines	Coverage Δ
src/node_sqlite.h	`80.39% <ø> (ø)`
src/node_sqlite.cc	`80.32% <84.81%> (+0.15%)`	⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Stale

mcollina

lgtm

nodejs-github-bot · 2026-01-11T20:40:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70778/

gurgunday

lgtm

src/node_sqlite.cc

ovflowd

SGTM!

nodejs-github-bot · 2026-01-15T11:47:35Z

Commit Queue failed

- Loading data for nodejs/node/pull/61311
✔  Done loading data for nodejs/node/pull/61311
----------------------------------- PR info ------------------------------------
Title      sqlite: add sqlite prepare options args (#61311)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     araujogui:sqlite-prepare-options -> nodejs:main
Labels     c++, semver-minor, author ready, needs-ci, commit-queue-squash, sqlite
Commits    5
 - sqlite: add sqlite prepare options args
 - sqlite: validate options before creating stmt
 - sqlite: revert set methods
 - sqlite: create options test cases
 - sqlite: add prepare options doc
Committers 1
 - Guilherme Araújo <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/61311
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61311
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 08 Jan 2026 01:44:47 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648468628
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648497153
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648737731
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/61311#pullrequestreview-3663415516
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-11T20:40:21Z: https://ci.nodejs.org/job/node-test-pull-request/70778/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - sqlite: add sqlite prepare options args
   ⚠  - sqlite: validate options before creating stmt
   ⚠  - sqlite: revert set methods
   ⚠  - sqlite: create options test cases
   ⚠  - sqlite: add prepare options doc
- Querying data for job/node-test-pull-request/70778/
✔  Build data downloaded
- Querying failures of job/node-test-commit/84751/
✔  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21030184729

ovflowd · 2026-01-15T11:54:29Z

cc @araujogui can you add an e-mail on your public profile? I also didn't see that CI didn't run for the rebase, let me trigger it.

ovflowd · 2026-01-15T11:55:14Z

fyi, I'm marking this as semver-minor, just because it changes API of an existing method, even if it is a new property. Just to be on the safe-side of things.

nodejs-github-bot · 2026-01-15T11:57:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70810/

ovflowd · 2026-01-18T22:42:54Z

cc @araujogui some tests are failing, unsure if it is ci flakiness tho, just fyi.

araujogui · 2026-01-19T13:13:39Z

cc @araujogui some tests are failing, unsure if it is ci flakiness tho, just fyi.

CI was flaky, it's working now!

ovflowd · 2026-01-19T14:04:28Z

cc @araujogui some tests are failing, unsure if it is ci flakiness tho, just fyi.

CI was flaky, it's working now!

Well, I'm referring to Jenkins CI, but let me run it.

nodejs-github-bot · 2026-01-19T14:05:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70886/

nodejs-github-bot · 2026-01-19T16:27:33Z

Commit Queue failed

- Loading data for nodejs/node/pull/61311
✔  Done loading data for nodejs/node/pull/61311
----------------------------------- PR info ------------------------------------
Title      sqlite: add sqlite prepare options args (#61311)
Author     Guilherme Araújo <[email protected]> (@araujogui)
Branch     araujogui:sqlite-prepare-options -> nodejs:main
Labels     c++, semver-minor, author ready, needs-ci, commit-queue-squash, sqlite
Commits    6
 - sqlite: add sqlite prepare options args
 - sqlite: validate options before creating stmt
 - sqlite: revert set methods
 - sqlite: create options test cases
 - sqlite: add prepare options doc
 - Merge branch 'main' into sqlite-prepare-options
Committers 2
 - Guilherme Araújo <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/61311
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61311
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 08 Jan 2026 01:44:47 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648468628
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648497153
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648737731
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/61311#pullrequestreview-3675813660
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-19T14:05:30Z: https://ci.nodejs.org/job/node-test-pull-request/70886/
- Querying data for job/node-test-pull-request/70886/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 61311
From https://github.com/nodejs/node
 * branch                  refs/pull/61311/merge -> FETCH_HEAD
✔  Fetched commits as 58f5da22237e..8caf617b8a40
--------------------------------------------------------------------------------
[main f0cc6e0341] sqlite: add sqlite prepare options args
 Author: Guilherme Araújo <[email protected]>
 Date: Wed Jan 7 20:02:16 2026 -0300
 4 files changed, 171 insertions(+), 167 deletions(-)
[main 1eaf0bd204] sqlite: validate options before creating stmt
 Author: Guilherme Araújo <[email protected]>
 Date: Thu Jan 8 17:00:12 2026 -0300
 1 file changed, 30 insertions(+), 13 deletions(-)
[main 4aa084cec5] sqlite: revert set methods
 Author: Guilherme Araújo <[email protected]>
 Date: Thu Jan 8 17:08:54 2026 -0300
 4 files changed, 167 insertions(+), 87 deletions(-)
[main 4657463032] sqlite: create options test cases
 Author: Guilherme Araújo <[email protected]>
 Date: Thu Jan 8 17:30:34 2026 -0300
 2 files changed, 345 insertions(+)
error: commit 8caf617b8a408ede11fc0200a0fd03bc77869a68 is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02bd55944d] sqlite: add prepare options doc
 Author: Guilherme Araújo <[email protected]>
 Date: Thu Jan 8 20:03:35 2026 -0300
 1 file changed, 11 insertions(+), 1 deletion(-)
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/21144724614

ovflowd · 2026-01-19T16:33:25Z

cc @araujogui I'm not close to a PC right now, apparently GitHub instead of rebasing added a merge commit:

Could you remove said commit and simply do a proper rebase?

nodejs-github-bot · 2026-01-19T19:22:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70894/

ovflowd · 2026-01-19T20:28:06Z

Flaky CI again 😭

nodejs-github-bot · 2026-01-19T20:37:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70895/

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 8, 2026

araujogui force-pushed the sqlite-prepare-options branch 2 times, most recently from b62c50e to 9bca95a Compare January 8, 2026 01:51

This comment was marked as outdated.

Sign in to view

araujogui force-pushed the sqlite-prepare-options branch from bb33e58 to 6da81dd Compare January 8, 2026 20:30

araujogui requested a review from Renegade334 January 8, 2026 20:31

araujogui force-pushed the sqlite-prepare-options branch from 45a8e19 to faaec9f Compare January 8, 2026 23:03

mcollina approved these changes Jan 11, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2026

Renegade334 approved these changes Jan 11, 2026

View reviewed changes

Renegade334 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 11, 2026

gurgunday approved these changes Jan 11, 2026

View reviewed changes

ovflowd reviewed Jan 14, 2026

View reviewed changes

src/node_sqlite.cc Show resolved Hide resolved

araujogui force-pushed the sqlite-prepare-options branch from faaec9f to 9418cab Compare January 14, 2026 14:35

ovflowd approved these changes Jan 15, 2026

View reviewed changes

ovflowd added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. semver-minor PRs that contain new features and should be released in the next minor version. labels Jan 15, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 15, 2026

ovflowd removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 15, 2026

ovflowd added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2026

ovflowd approved these changes Jan 18, 2026

View reviewed changes

ovflowd added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026

ovflowd added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 19, 2026

araujogui added 5 commits January 19, 2026 14:39

sqlite: add sqlite prepare options args

ba0bc16

sqlite: validate options before creating stmt

1ab88e6

sqlite: revert set methods

8b504bc

sqlite: create options test cases

85076e6

sqlite: add prepare options doc

1fa1c8a

araujogui force-pushed the sqlite-prepare-options branch from 8caf617 to 1fa1c8a Compare January 19, 2026 17:39

ovflowd approved these changes Jan 19, 2026

View reviewed changes

ovflowd added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026

ovflowd added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026

Uh oh!

sqlite: add sqlite prepare options args #61311

Are you sure you want to change the base?

sqlite: add sqlite prepare options args #61311

Conversation

araujogui commented Jan 8, 2026

Uh oh!

nodejs-github-bot commented Jan 8, 2026

Uh oh!

codecov bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 11, 2026

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 15, 2026

Uh oh!

ovflowd commented Jan 15, 2026

Uh oh!

ovflowd commented Jan 15, 2026

Uh oh!

nodejs-github-bot commented Jan 15, 2026

Uh oh!

ovflowd commented Jan 18, 2026

Uh oh!

araujogui commented Jan 19, 2026

Uh oh!

ovflowd commented Jan 19, 2026

Uh oh!

nodejs-github-bot commented Jan 19, 2026

Uh oh!

nodejs-github-bot commented Jan 19, 2026

Uh oh!

ovflowd commented Jan 19, 2026

Uh oh!

nodejs-github-bot commented Jan 19, 2026

Uh oh!

ovflowd commented Jan 19, 2026

Uh oh!

nodejs-github-bot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jan 8, 2026 •

edited

Loading