Skip to content

docs: fix two typos in pipeline CONTRIBUTING.md#4263

Merged
pinin4fjords merged 4 commits intonf-core:devfrom
pinin4fjords:docs/contributing-focused-typo
May 5, 2026
Merged

docs: fix two typos in pipeline CONTRIBUTING.md#4263
pinin4fjords merged 4 commits intonf-core:devfrom
pinin4fjords:docs/contributing-focused-typo

Conversation

@pinin4fjords
Copy link
Copy Markdown
Member

@pinin4fjords pinin4fjords commented May 5, 2026

Summary

Two tiny copy fixes in the file every nf-core pipeline inherits as docs/CONTRIBUTING.md after a template sync:

  • line 49: `Keep PRs as small and `focussed` as possible` → `focused`. `focussed` (double-s) is dictionary-correct British English but is the less-common variant; `focused` is preferred in modern AmE and most BrE style guides today.
  • line 54: `see the the [blog post]` → `see the [blog post]`. Duplicate "the".

Caught downstream during the nf-core/rnaseq#1827 4.0.2 template merge review (h/t @erikrikarddaniel for the `focussed` flag).

Test plan

  • No code paths touched. The pipeline-template render is unchanged structurally; only two strings differ.

🤖 Generated with Claude Code

mashehu and others added 2 commits April 30, 2026 15:10
@mashehu @nvnieuwk
dev -> main for 4.0.2 (nf-core#4255)
b6c5737 
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
@pinin4fjords
docs: fix two typos in pipeline CONTRIBUTING.md (focussed -> focused,…
22fcbbc 
… duplicate 'the')

Both typos in nf_core/pipeline-template/docs/CONTRIBUTING.md ship with
every pipeline that adopts the 4.0 template. 'focussed' is a less-common
British spelling; 'focused' is preferred in modern AmE and BrE style
guides. The second hit (line 54) is a duplicated 'the the'.

Caught downstream during the nf-core/rnaseq#1827 template merge review.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the pinin4fjords/tools main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the pinin4fjords/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.79%. Comparing base (7eb2728) to head (dfdea91).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

erikrikarddaniel
erikrikarddaniel approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine when you switch branch :-)

@pinin4fjords pinin4fjords changed the base branch from main to dev May 5, 2026 16:56
@pinin4fjords
chore: trigger CI after base branch update
59d428e
@pinin4fjords
Merge upstream/dev into docs/contributing-focused-typo
dfdea91 
Resolves the conflicts surfaced after the PR base flipped from main
to dev. Takes upstream/dev for pyproject.toml and uv.lock (the
release-bump changes from b6c5737 are now redundant on dev).

# Conflicts:
#	pyproject.toml
#	uv.lock
@ewels
Copy link
Copy Markdown
Member

ewels commented May 5, 2026

I also write focussed but I guess we're in the minority @pinin4fjords 😅

@pinin4fjords pinin4fjords merged commit b291b0b into nf-core:dev May 5, 2026
113 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewels ewels ewels approved these changes

@erikrikarddaniel erikrikarddaniel erikrikarddaniel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pinin4fjords @ewels @erikrikarddaniel @mashehu