Nmc/5422 sharing pending share manage access and share leads to empty sidebar with error message#452
Merged
suet-kei-chan merged 9 commits intostable32from Mar 23, 2026
Conversation
…bar error The sharing-status-menu action was enabled unconditionally, causing it to appear in the pendingshares view where files are not yet in the user's filesystem. Clicking it triggered the sidebar with an unresolvable path, resulting in an empty sidebar with an error message. Now the action is excluded from the pendingshares view.
Pending share rows already show Accept/Reject actions. The sharing-popup button has no valid context on unaccepted shares and should not be visible. Uses :has() to target rows containing the accept-share action.
This reverts commit a594e06.
…pty sidebar error" This reverts commit ba79ef8.
Use :has(.files-list__row-action-accept-share) scoped within #app-content-vue .files-list:not(.files-list--grid) to target only pending share rows with sufficient specificity to override the existing display:flex on .files-list__row-action-sharing-popup.
…ending rows Use :not() selector to hide every action menu item that is not accept-share or reject-share, including separators and any future items.
memurats
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.