Repository navigation
fix: hide "open locally" button on public shares - #6214
Merged
Merged
Conversation
Tests to make sure the Insert_Button post message is not emitted in the following cases: - The document is being edited via a public share - There is no logged-in user (editor is a guest) The specific button in question is the "Open locally" button Assisted-by: ClaudeCode:claude-opus-5[1m] Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
juliusknorr
reviewed
Oct 20, 2026
juliusknorr
approved these changes
Oct 20, 2026
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
nitpick, but good to get in 👍
Hides the "Open in local editor" button if editing a document via a public share or if the editor is not logged-in (guest user). Assisted-by: ClaudeCode:claude-opus-5[1m] Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
force-pushed
the
fix/hide-open-locally-on-public-shares
branch
from
October 20, 2026 19:24
d5cd44c to
2b0f6ef
Compare
Collaborator
Author
|
/backport to stable35 |
Collaborator
Author
|
/backport to stable34 please |
Collaborator
Author
|
/backport to stable33 please |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Open in local editor" button should not be offered when editing a document in the following scenarios:
The diff is mostly changes/additions to tests; the
cy.waitForPostMessage()logic was made separate so that it can also be used in its new negative equivalentcy.shouldNotHavePostMessage(). This was the only surefire way to verify the button is never inserted; it's not feasible to check for the DOM element specifically because the insertion causes Collabora to rebuild the entire notebook bar. This means the test would actually pass even though the button is still there in the end because the test is being run against the initial notebook bar that doesn't yet contain the button.Aside from tests, the actual change is very minimal.
The changes in this PR are AI-assisted.
Checklist